feat: azure-key-vault driver

[itpropro]

No description provided.

[danielroe]

looks good to me! what about something like https://github.com/peveuve/ms-vault-mock for testing?

[itpropro]

looks good to me! what about something like https://github.com/peveuve/ms-vault-mock for testing?

Great find, I will check that. The main problem would be that it hides the actual slowness of Azure Kay Vault, but for unit testing it's great.

[itpropro]

looks good to me! what about something like https://github.com/peveuve/ms-vault-mock for testing?

I tested that and it's quite complex to get it to run with the current version of Key Vault packages, as you have to generate cert pairs, disable HTTPS validation and create some workaround due so recent API changes. The package wasn't updated for two years, which means there are a lot of old and complex dependencies from lodash to express and the Key Vault API itself is also old and has no support for purge and soft delete.
I would prefer a free Key Vault hosted instance tbh @danielroe

[pi0]

Thanks (also skipping tests for now. trusting it works as expected)

[itpropro]

Thanks (also skipping tests for now. trusting it works as expected)

The only thing about this driver (different to my other PRs) is that Azure Key Vault is a very slow service. The clear action can take a minute, although I tried to make it at least a little better with concurrency.
It’s also in the README, but if you don’t like it, because of the actual service slowness, we can revisit it.

[pi0]

Slowness is okay and i guess somehow expected for encryption. As long as we can test locally we can add some additional tests only running in CI.