Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vercel-blob driver #472

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

PikiLee
Copy link
Contributor

@PikiLee PikiLee commented Aug 12, 2024

resolves #264

@pi0 pi0 added the driver label Sep 4, 2024
@ryanweston

This comment was marked as off-topic.

@MickL

This comment was marked as off-topic.

@pi0
Copy link
Member

pi0 commented Dec 10, 2024

Thanks for PR. I've pushed a few refactors and improvements.

While tests pass against prod, what really concerns me is that we have to make every piece of data publicly accessible, and implementation also requires that we disable random suffixes.

I've added a warning to docs and runtime also but still users might mistakenly leak private info as only and only this driver on server-side has this behavior today. (netlify Blob for example in contrast, AFAIK encrypts and makes them always private).

I contacted vercel team to ask about private support but in the meantime, anyone can directly use @vercel/blob in their projects and there is KV storage as well powered by upstash.

@pi0
Copy link
Member

pi0 commented Dec 11, 2024

Update: Private access will eventually be supported.

For now updated driver to require access: "public" config explicitly to make sure devs know the fact.

@pi0 pi0 merged commit c8441b3 into unjs:main Dec 11, 2024
pi0 added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel Blob Support
4 participants