-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: typed storage interface #509
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 65.05% 62.93% -2.12%
==========================================
Files 39 39
Lines 4055 3343 -712
Branches 487 579 +92
==========================================
- Hits 2638 2104 -534
+ Misses 1408 1236 -172
+ Partials 9 3 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice to see!
I wonder if we could support extracting keys with :
- so having a namespace:child
would get the right types with a base
of namespace
and a key of child
....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Refer: #508
We can improve the ts type as follows:
and get hints as you type:
