test: clear storage after each test #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clears the storage after each test such that they no longer rely on run order, etc.
pi0
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
- Coverage 65.05% 58.59% -6.47%
==========================================
Files 39 43 +4
Lines 4055 3649 -406
Branches 487 580 +93
==========================================
- Hits 2638 2138 -500
- Misses 1408 1507 +99
+ Partials 9 4 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears the storage after each test such that they no longer rely on run order, etc.
Note that the two snapshot tests have been massively dumbed down. Though I'm not sure this is a problem since the underlying driver tests already test the data types etc. Leaving these to purely test that a snapshot can be produced.
let me know what you think