Add cluster-manual-failover-timeout desc in CLUSTER FAILOVER command page #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page Signed-off-by: Binbin <[email protected]>
madolson
reviewed
Feb 26, 2025
Comment on lines
+19
to
+22
| The default failover timeout is 5000ms, it is possible to configure the timeout | ||
| via `cluster-manual-failover-timeout` configuration item (added in Valkey 8.1) | ||
| and decide how long the primary will pause in the worst case scenario, i.e. the | ||
| manual failover timed out due to the insufficient votes. |
There was a problem hiding this comment.
Suggested change
| The default failover timeout is 5000ms, it is possible to configure the timeout | |
| via `cluster-manual-failover-timeout` configuration item (added in Valkey 8.1) | |
| and decide how long the primary will pause in the worst case scenario, i.e. the | |
| manual failover timed out due to the insufficient votes. | |
| There is a built-in timeout for the primary to resume processing queries if the | |
| replica does not catch quickly enough or is unable to secure the votes to take over. | |
| The default failover timeout is 5000ms. It is possible to configure the timeout | |
| via the `cluster-manual-failover-timeout` configuration parameter (added in Valkey 8.1) | |
| and decide how long the primary will pause in the worst case scenario. |
Looks good, but I don't see context on the timeout, so maybe we can add one sentence for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See valkey-io/valkey#1690