Automatically configure ThreadPool size based on CPU core count

[yairgott]

The ThreadPool size is typically configured according to the number of CPU cores available on the host. Extending the module's startup logic to automatically set the ThreadPool size based on CPU core count, unless explicitly configured, would be a practical enhancement, reducing manual setup and ensuring optimal performance by default.

[dpbnasika]

@yairgott I could do this as well !!.

From my understanding,
Typically when i run it in my local dev setup after following the developer guide, i see that , during loading time, you are explicitly configuring to make it run in this way:

/path/to/valkey-server "--loadmodule /path/to/libvalkeysearch.so --reader-threads 64 --writer-threads 64".

I ran it with 16 as my vCPU count is 16, so if you do not mention this explicitly, by default it would take 10 and 30 i believe, (correct me if i am wrong), as i also mentioned in the other issue [https://github.com//issues/39], so now this default value has to be configured based on the vCPU count instead of hard coding the writer and reader threads, and support cross platform too to automatically get the the vCPU count. right?.

[yairgott]

Yes, but the ThreadPool size should align with the host's physical cores, not its vCPUs.

[dpbnasika]

@yairgott does the build run successfully in macos( apple silicon ) currently?, I get errors related to pthread functions. But on linux, i dint face any problem.

[yairgott]

I've never tried to build in macos and I wouldn't be surprise if it doesn't compile.

The recommended way to develop is using the dev container which is set with Ubuntu 24 IIRC. Please refer to our developer guide.