Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canAddMoreEntries setting does not seem to update on block deletion event. #11

Closed
sandrodunkel opened this issue Jun 6, 2024 · 9 comments

Comments

@sandrodunkel
Copy link

I have a matrix with a max entries setting of 1. When deleting this one block to add another type, the add-buttons are correctly displayed again, but I can't actually add another block. I first have to reload the page and only then I'm able to create a new block again. It seems like you need to update the canAddMoreEntries-thingy when deleting a block.

@vandres
Copy link
Owner

vandres commented Jun 6, 2024

On it now...

@vandres
Copy link
Owner

vandres commented Jun 6, 2024

Bildschirmaufnahme.2024-06-06.um.13.51.47.mov

@sandrodunkel Can you please give me more details. I tried a very simple example, and it seems to work. With either delete buttons

@sandrodunkel
Copy link
Author

I'm inside a global set, maybe this has something to do with it? Although I can't really imagine that that's the problem. Is there anything I could show you in the backend debug bar that could help you?

Screen.Recording.2024-06-06.at.14.19.13.mov

@vandres
Copy link
Owner

vandres commented Jun 6, 2024

I will try your use case with the global sets. I would stongly recommend though, to not use Category and GlobalSet anymore.

@sandrodunkel
Copy link
Author

Clients seem to like the separation of entries and globals. Also, there have been talks of getting rid of them since late Craft 3. I believe it, when I see it^^

@vandres
Copy link
Owner

vandres commented Jun 6, 2024

I can reproduce it in Global Sets

@vandres
Copy link
Owner

vandres commented Jun 6, 2024

@sandrodunkel Can you confirm, that it also happens, without the plugin being enbaled? Looks like a core bug

@sandrodunkel
Copy link
Author

@vandres Can confirm! I will open an issue in the craftcms repo. Since this has nothing to do with your plugin, I will close this issue. Thanks.

@sandrodunkel
Copy link
Author

craftcms/cms#15158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants