Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): Fix update_repo when there are untracked files (backport) #424

Conversation

jfpedroza
Copy link
Contributor

@jfpedroza jfpedroza commented Sep 25, 2022

Backport of #422 for v0.13

#395

@tony tony self-requested a review September 25, 2022 04:30
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #424 (caf47b5) into v0.13.x (ff9247b) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           v0.13.x     #424      +/-   ##
===========================================
+ Coverage    70.38%   70.71%   +0.32%     
===========================================
  Files           21       21              
  Lines         1891     1895       +4     
===========================================
+ Hits          1331     1340       +9     
+ Misses         560      555       -5     
Impacted Files Coverage Δ
libvcs/projects/git.py 78.16% <100.00%> (+1.76%) ⬆️
tests/projects/test_git.py 99.43% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tony added a commit that referenced this pull request Sep 26, 2022
Fixes #395, Fixes #422 (alternative)

Potential backport is at #424
@tony
Copy link
Member

tony commented Sep 26, 2022

@jfpedroza You can close this for now if its not needed

Per our conversation, if vcspull 1.13.0 and libvcs v0.17.0 have any bumps and you need to go back to v1.13.x, we can revisit this

@jfpedroza jfpedroza closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants