From f229e364f9270fb9b38c3e6f8f98371be1d68867 Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Mon, 23 Dec 2019 12:44:51 +0100 Subject: [PATCH 1/4] fix: add release script --- generators/app/templates/typescript/auth/_package.json | 1 + .../app/templates/typescript/middleware/_package.json | 1 + .../app/templates/typescript/storage/_package.json | 9 +++++++-- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/generators/app/templates/typescript/auth/_package.json b/generators/app/templates/typescript/auth/_package.json index 96c2d3fe..5aaede59 100644 --- a/generators/app/templates/typescript/auth/_package.json +++ b/generators/app/templates/typescript/auth/_package.json @@ -30,6 +30,7 @@ "repository": "<%= repository %>", "author": "<%= authorName %> <<%= authorEmail %>>", "scripts": { + "release": "standard-version -a -s", "build": "npm run build:types && npm run build:js", "build:js": "babel src/ --out-dir lib --extensions \".ts,.tsx\"", "build:types": "tsc --emitDeclarationOnly", diff --git a/generators/app/templates/typescript/middleware/_package.json b/generators/app/templates/typescript/middleware/_package.json index 46c99cdb..221ef570 100644 --- a/generators/app/templates/typescript/middleware/_package.json +++ b/generators/app/templates/typescript/middleware/_package.json @@ -31,6 +31,7 @@ "repository": "<%= repository %>", "author": "<%= authorName %> <<%= authorEmail %>>", "scripts": { + "release": "standard-version -a -s", "build": "npm run build:types && npm run build:js", "build:js": "babel src/ --out-dir lib --extensions \".ts,.tsx\"", "build:types": "tsc --emitDeclarationOnly", diff --git a/generators/app/templates/typescript/storage/_package.json b/generators/app/templates/typescript/storage/_package.json index 5ee02968..f265604d 100644 --- a/generators/app/templates/typescript/storage/_package.json +++ b/generators/app/templates/typescript/storage/_package.json @@ -8,17 +8,21 @@ "engines": { "node": ">=10" }, + "dependencies": { + "@verdaccio/commons-api": "^8.5.0", + "@verdaccio/streams": "^8.5.0" + }, "devDependencies": { "@types/jest": "^24.0.21", "@types/node": "^12.12.5", "@types/express": "^4.17.1", - "@typescript-eslint/eslint-plugin": "2.12.0", + "@typescript-eslint/eslint-plugin": "^2.12.0", "@verdaccio/babel-preset": "^8.5.0", "@verdaccio/eslint-config": "^8.5.0", "@verdaccio/types": "^8.5.0", "eslint": "^6.6.0", "jest": "^24.9.0", - "prettier": "1.19.1", + "prettier": "^1.19.1", "standard-version": "^7.0.0", "typescript": "^3.7.2" }, @@ -27,6 +31,7 @@ "repository": "<%= repository %>", "author": "<%= authorName %> <<%= authorEmail %>>", "scripts": { + "release": "standard-version -a -s", "build": "npm run build:types && npm run build:js", "build:js": "babel src/ --out-dir lib --extensions \".ts,.tsx\"", "build:types": "tsc --emitDeclarationOnly", From 342ee4bd02f4e01e795095a779cd9a76908ff6fe Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Mon, 23 Dec 2019 23:56:57 +0100 Subject: [PATCH 2/4] chore: add storage database handler --- generators/app/templates/.eslintrc | 5 + .../{storageManager.ts => PackageStorage.ts} | 0 .../templates/typescript/storage/src/index.ts | 51 +------ .../typescript/storage/src/plugin.ts | 138 ++++++++++++++++++ 4 files changed, 144 insertions(+), 50 deletions(-) create mode 100644 generators/app/templates/.eslintrc rename generators/app/templates/typescript/storage/src/{storageManager.ts => PackageStorage.ts} (100%) create mode 100644 generators/app/templates/typescript/storage/src/plugin.ts diff --git a/generators/app/templates/.eslintrc b/generators/app/templates/.eslintrc new file mode 100644 index 00000000..29335221 --- /dev/null +++ b/generators/app/templates/.eslintrc @@ -0,0 +1,5 @@ +{ + "rules": { + "@typescript-eslint/no-unused-vars": 0 + } +} \ No newline at end of file diff --git a/generators/app/templates/typescript/storage/src/storageManager.ts b/generators/app/templates/typescript/storage/src/PackageStorage.ts similarity index 100% rename from generators/app/templates/typescript/storage/src/storageManager.ts rename to generators/app/templates/typescript/storage/src/PackageStorage.ts diff --git a/generators/app/templates/typescript/storage/src/index.ts b/generators/app/templates/typescript/storage/src/index.ts index 6fe12ab8..717000d3 100644 --- a/generators/app/templates/typescript/storage/src/index.ts +++ b/generators/app/templates/typescript/storage/src/index.ts @@ -1,50 +1 @@ -import { - Logger, - Callback, - IPluginStorage, - PluginOptions, - IPackageStorage -} from "@verdaccio/types"; - -import { CustomConfig } from "../types/index"; - -export default class VerdaccioStoragePlugin - implements IPluginStorage { - public logger: Logger; - public constructor( - config: CustomConfig, - options: PluginOptions - ) {} - - public async getSecret(): Promise {} - - public async setSecret(secret: string): Promise {} - - /** - * Add a new element. - * @param {*} name - * @return {Error|*} - */ - public add(name: string, callback: Callback): void {} - - public search( - onPackage: Callback, - onEnd: Callback, - validateName: Function - ): void {} - - /** - * Remove an element from the database. - * @param {*} name - * @return {Error|*} - */ - public remove(name: string, callback: Callback): void {} - - /** - * Return all database elements. - * @return {Array} - */ - public get(callback: Callback): void {} - - public getPackageStorage(packageInfo: string): IPackageStorage {} -} +export { default } from './plugin'; \ No newline at end of file diff --git a/generators/app/templates/typescript/storage/src/plugin.ts b/generators/app/templates/typescript/storage/src/plugin.ts new file mode 100644 index 00000000..05999104 --- /dev/null +++ b/generators/app/templates/typescript/storage/src/plugin.ts @@ -0,0 +1,138 @@ +import { + Logger, + Callback, + IPluginStorage, + PluginOptions, + IPackageStorage, + TokenFilter, + Token, + Config, + onEndSearchPackage, + onSearchPackage, + onValidatePackage +} from '@verdaccio/types'; +import { getInternalError } from '@verdaccio/commons-api'; + +import { CustomConfig } from '../types/index'; + +import PackageStorage from './PackageStorage'; + +export default class VerdaccioStoragePlugin implements IPluginStorage { + config: CustomConfig & Config; + version?: string; + public logger: Logger; + public constructor( + config: CustomConfig, + options: PluginOptions + ) { + this.config = config; + this.logger = options.logger; + } + + /** + * + */ + public async getSecret(): Promise { + /** + * return await resolveSecret(); + */ + } + + public async setSecret(secret: string): Promise { + /** + * return await getYourSecret(); + */ + } + + /** + * Add a new element. + * @param {*} name + * @return {Error|*} + */ + public add(name: string, callback: Callback): void {} + + /** + * Perform a search in your registry + * @param onPackage + * @param onEnd + * @param validateName + */ + public search( + onPackage: onSearchPackage, + onEnd: onEndSearchPackage, + validateName: onValidatePackage + ): void { + /** + * Example of implementation: + * try { + * someApi.getPackages((items) => { + * items.map(() => { + * if (validateName(item.name)) { + * onPackage(item); + * } + * }); + * onEnd(); + * } catch(err) { + * onEnd(err); + * } + * }); + */ + } + + /** + * Remove an element from the database. + * @param {*} name + * @return {Error|*} + */ + public remove(name: string, callback: Callback): void { + /** + * Example of implementation + database.getPackage(name, (item, err) => { + if (err) { + callback(getInternalError('your own message here')); + } + + // if all goes well we return nothing + callback(null); + } + */ + } + + /** + * Return all database elements. + * @return {Array} + */ + public get(callback: Callback): void { + /* + Example of implementation + database.getAll((allItems, err) => { + callback(err, allItems); + }) + */ + } + + /** + * Create an instance of the `PackageStorage` + * @param packageInfo + */ + public getPackageStorage(packageInfo: string): IPackageStorage { + return new PackageStorage(this.config, packageInfo, this.logger); + } + + /** + * methods for npm token support + * info: https://github.com/verdaccio/verdaccio/pull/1427 + */ + + public saveToken(token: Token): Promise { + throw new Error('Method not implemented.'); + } + + public deleteToken(user: string, tokenKey: string): Promise { + throw new Error('Method not implemented.'); + } + + public readTokens(filter: TokenFilter): Promise { + throw new Error('Method not implemented.'); + } +} From 2d3b086db1eebd90547685f4c95cf9174dfd9bb1 Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Wed, 25 Dec 2019 12:32:33 +0100 Subject: [PATCH 3/4] refactor: add documented storage template --- generators/app/templates/javascript/.eslintrc | 5 + .../javascript/storage/_package.json | 1 - .../javascript/storage/src/PackageStorage.js | 153 ++++++++++++++++ .../templates/javascript/storage/src/index.js | 36 +--- .../javascript/storage/src/plugin.js | 106 +++++++++++ .../javascript/storage/src/storageManager.js | 19 -- .../templates/typescript/auth/_package.json | 2 +- .../typescript/middleware/_package.json | 2 +- .../typescript/storage/_package.json | 4 +- .../typescript/storage/src/PackageStorage.ts | 171 ++++++++++++++++-- .../typescript/storage/src/plugin.ts | 8 +- package.json | 2 +- yarn.lock | 8 +- 13 files changed, 434 insertions(+), 83 deletions(-) create mode 100644 generators/app/templates/javascript/.eslintrc create mode 100644 generators/app/templates/javascript/storage/src/PackageStorage.js create mode 100644 generators/app/templates/javascript/storage/src/plugin.js delete mode 100644 generators/app/templates/javascript/storage/src/storageManager.js diff --git a/generators/app/templates/javascript/.eslintrc b/generators/app/templates/javascript/.eslintrc new file mode 100644 index 00000000..bb390f92 --- /dev/null +++ b/generators/app/templates/javascript/.eslintrc @@ -0,0 +1,5 @@ +{ + "rules": { + "no-unused-vars": 0 + } +} \ No newline at end of file diff --git a/generators/app/templates/javascript/storage/_package.json b/generators/app/templates/javascript/storage/_package.json index 60e98030..207628d1 100644 --- a/generators/app/templates/javascript/storage/_package.json +++ b/generators/app/templates/javascript/storage/_package.json @@ -15,7 +15,6 @@ "devDependencies": { "@verdaccio/babel-preset": "^8.5.0", "@verdaccio/eslint-config": "^8.5.0", - "@verdaccio/types": "^8.5.0", "eslint": "^6.6.0", "jest": "^24.9.0", "prettier": "^1.19.1", diff --git a/generators/app/templates/javascript/storage/src/PackageStorage.js b/generators/app/templates/javascript/storage/src/PackageStorage.js new file mode 100644 index 00000000..014664d4 --- /dev/null +++ b/generators/app/templates/javascript/storage/src/PackageStorage.js @@ -0,0 +1,153 @@ +import { UploadTarball, ReadTarball } from "@verdaccio/streams"; +import { getNotFound, getConflict, getInternalError } from '@verdaccio/commons-api'; + + +export default class StoragePluginManage { + constructor(packageName, helper, config, logger) { + this.logger = logger; + this.packageName = packageName; + this.config = config; + } + + /** + * Handle a metadata update and + * @param name + * @param updateHandler + * @param onWrite + * @param transformPackage + * @param onEnd + */ + updatePackage(name, updateHandler, onWrite, transformPackage, onEnd) { + /** + * Example of implementation: + this.customStore.get().then((pkg: Package) => { + updateHandler(pkg, function onUpdateFinish(err) { + if (err) { + onEnd(err); + } else { + onWrite(name, pkg, onEnd); + } + }) + }); + */ + } + + /** + * Delete a specific file (tarball or package.json) + * @param fileName + * @param callback + */ + deletePackage(fileName, callback) { + /** + * Example of implementation: + this.customStore.delete(fileName, (err) => { + if (err) { + callback(err); + } else { + callback(null); + } + }) + */ + } + + /** + * Delete a package (folder, path) + * This happens after all versions ar tarballs have been removed. + * @param callback + */ + removePackage(callback) { + /** + * Example of implementation: + this.customStore.removePackage((err) => { + if (err) { + callback(err); + } else { + callback(null); + } + }) + */ + } + + /** + * Publish a new package (version). + * @param name + * @param data + * @param callback + */ + createPackage(name, metadata, cb) { + /** + * Example of implementation: + * this.customStore.create(name, data).then(err => { + if (err.notFound) { + callback(getNotFound()); + } else if (err.alreadyExist) { + callback(getConflict()); + } else { + callback(null); + } + }) + */ + } + + /** + * Perform write anobject to the storage. + * Similar to updatePackage but without middleware handlers + * @param pkgName package name + * @param pkg package metadata + * @param callback + */ + savePackage(name, value, cb) { + /* + Example of implementation: + this.cumstomStore.write(pkgName, pkgName).then(data => { + callback(null); + }).catch(err => { + callback(getInternalError(err.message)); + }) + */ + } + + /** + * Read a package from storage + * @param pkgName package name + * @param callback + */ + readPackage(name, cb) { + /** + * Example of implementation: + * this.customStorage.read(name, (err, pkg: Package) => { + if (err.fooError) { + callback(getInternalError(err)) + } else if (err.barError) { + callback(getNotFound()); + } else { + callback(null, pkg) + } + }); + */ + } + + /** + * Create writtable stream (write a tarball) + * @param name + */ + writeTarball(name) { + /** + * Example of implementation: + * const stream = new UploadTarball({}); + return stream; + */ + } + + /** + * Create a readable stream (read a from a tarball) + * @param name + */ + readTarball(name) { + /** + * Example of implementation: + * const stream = new ReadTarball({}); + return stream; + */ + } +}; diff --git a/generators/app/templates/javascript/storage/src/index.js b/generators/app/templates/javascript/storage/src/index.js index 565c614c..717000d3 100644 --- a/generators/app/templates/javascript/storage/src/index.js +++ b/generators/app/templates/javascript/storage/src/index.js @@ -1,35 +1 @@ -class VerdaccioStoragePlugin { - constructor(config, options) {} - - getSecret() {} - - setSecret(secret) {} - - /** - * Add a new element. - * @param {*} name - * @return {Error|*} - */ - add(name, cb) {} - - search(onPackage, onEnd, validateName) {} - - /** - * Remove an element from the database. - * @param {*} name - * @return {Error|*} - */ - remove(name, cb) {} - - /** - * Return all database elements. - * @return {Array} - */ - get(cb) {} - - getPackageStorage(packageName) {} -} - -module.exports = (config, options) => { - return new VerdaccioStoragePlugin(config, options); -}; +export { default } from './plugin'; \ No newline at end of file diff --git a/generators/app/templates/javascript/storage/src/plugin.js b/generators/app/templates/javascript/storage/src/plugin.js new file mode 100644 index 00000000..b504bb5f --- /dev/null +++ b/generators/app/templates/javascript/storage/src/plugin.js @@ -0,0 +1,106 @@ +import PackageStorage from './PackageStorage'; + +class VerdaccioStoragePlugin { + constructor(config, options) { + this.config = config; + this.logger = options.logger; + } + + async getSecret() { + /** + * return await resolveSecret(); + */ + } + + async setSecret(secret) { + /** + * return await getYourSecret(); + */ + } + + /** + * Add a new element. + * @param {*} name + * @return {Error|*} + */ + add(name, cb) {} + + search(onPackage, onEnd, validateName) { + /** + * Example of implementation: + * try { + * someApi.getPackages((items) => { + * items.map(() => { + * if (validateName(item.name)) { + * onPackage(item); + * } + * }); + * onEnd(); + * } catch(err) { + * onEnd(err); + * } + * }); + */ + } + + /** + * Remove an element from the database. + * @param {*} name + * @return {Error|*} + */ + remove(name, callback) { + /** + * Example of implementation + database.getPackage(name, (item, err) => { + if (err) { + callback(getInternalError('your own message here')); + } + + // if all goes well we return nothing + callback(null); + } + */ + } + + /** + * Return all database elements. + * @return {Array} + */ + get(callback) { + /* + Example of implementation + database.getAll((allItems, err) => { + callback(err, allItems); + }) + */ + } + + /** + * Create an instance of the `PackageStorage` + * @param packageInfo + */ + getPackageStorage(packageInfo) { + return new PackageStorage(this.config, packageInfo, this.logger); + } + + /** + * All methods for npm token support + * more info here https://github.com/verdaccio/verdaccio/pull/1427 + */ + + saveToken(token) { + throw new Error('Method not implemented.'); + } + + deleteToken(user, tokenKey) { + throw new Error('Method not implemented.'); + } + + readTokens(filter) { + throw new Error('Method not implemented.'); + } +} + +export default (config, options) => { + return new VerdaccioStoragePlugin(config, options); +}; diff --git a/generators/app/templates/javascript/storage/src/storageManager.js b/generators/app/templates/javascript/storage/src/storageManager.js deleted file mode 100644 index bacaf770..00000000 --- a/generators/app/templates/javascript/storage/src/storageManager.js +++ /dev/null @@ -1,19 +0,0 @@ -module.exports = class StoragePluginManage { - constructor(name, helper, config, logger) {} - - updatePackage(name, updateHandler, onWrite, transformPackage, onEnd) {} - - deletePackage(fileName, cb) {} - - removePackage(callback) {} - - createPackage(name, metadata, cb) {} - - savePackage(name, value, cb) {} - - readPackage(name, cb) {} - - writeTarball(name) {} - - readTarball(name) {} -}; diff --git a/generators/app/templates/typescript/auth/_package.json b/generators/app/templates/typescript/auth/_package.json index 44523ae6..ecf792ec 100644 --- a/generators/app/templates/typescript/auth/_package.json +++ b/generators/app/templates/typescript/auth/_package.json @@ -18,7 +18,7 @@ "@typescript-eslint/eslint-plugin": "^2.12.0", "@verdaccio/babel-preset": "^8.5.0", "@verdaccio/eslint-config": "^8.5.0", - "@verdaccio/types": "^8.5.0", + "@verdaccio/types": "^8.5.2", "eslint": "^6.6.0", "jest": "^24.9.0", "prettier": "^1.19.1", diff --git a/generators/app/templates/typescript/middleware/_package.json b/generators/app/templates/typescript/middleware/_package.json index e92c88bd..6f439018 100644 --- a/generators/app/templates/typescript/middleware/_package.json +++ b/generators/app/templates/typescript/middleware/_package.json @@ -19,7 +19,7 @@ "@typescript-eslint/eslint-plugin": "^2.12.0", "@verdaccio/babel-preset": "^8.5.0", "@verdaccio/eslint-config": "^8.5.0", - "@verdaccio/types": "^8.5.0", + "@verdaccio/types": "^8.5.2", "eslint": "^6.6.0", "jest": "^24.9.0", "prettier": "^1.19.1", diff --git a/generators/app/templates/typescript/storage/_package.json b/generators/app/templates/typescript/storage/_package.json index 70e342d0..c2b188f6 100644 --- a/generators/app/templates/typescript/storage/_package.json +++ b/generators/app/templates/typescript/storage/_package.json @@ -10,7 +10,7 @@ }, "dependencies": { "@verdaccio/commons-api": "^8.5.0", - "@verdaccio/streams": "^8.5.0" + "@verdaccio/streams": "^8.5.2" }, "devDependencies": { "@types/jest": "^24.0.21", @@ -19,7 +19,7 @@ "@typescript-eslint/eslint-plugin": "^2.12.0", "@verdaccio/babel-preset": "^8.5.0", "@verdaccio/eslint-config": "^8.5.0", - "@verdaccio/types": "^8.5.0", + "@verdaccio/types": "^8.5.2", "eslint": "^6.6.0", "jest": "^24.9.0", "prettier": "^1.19.1", diff --git a/generators/app/templates/typescript/storage/src/PackageStorage.ts b/generators/app/templates/typescript/storage/src/PackageStorage.ts index f55af0b3..0e40228c 100644 --- a/generators/app/templates/typescript/storage/src/PackageStorage.ts +++ b/generators/app/templates/typescript/storage/src/PackageStorage.ts @@ -1,44 +1,183 @@ import { Callback, Logger, + ILocalPackageManager, + StorageUpdateCallback, + PackageTransformer, + StorageWriteCallback, + CallbackAction, Package, - ILocalPackageManager + ReadPackageCallback } from "@verdaccio/types"; import { UploadTarball, ReadTarball } from "@verdaccio/streams"; +import { getNotFound, getConflict, getInternalError } from '@verdaccio/commons-api'; import { CustomConfig } from "../types/index"; export default class StoragePluginManage implements ILocalPackageManager { public logger: Logger; + public packageName: string; + public config: CustomConfig; public constructor( config: CustomConfig, packageName: string, logger: Logger - ) {} + ) { + this.logger = logger; + this.packageName = packageName; + this.config = config; + } + /** + * Handle a metadata update and + * @param name + * @param updateHandler + * @param onWrite + * @param transformPackage + * @param onEnd + */ public updatePackage( name: string, - updateHandler: Callback, - onWrite: Callback, - transformPackage: Function, - onEnd: Callback - ): void {} + updateHandler: StorageUpdateCallback, + onWrite: StorageWriteCallback, + transformPackage: PackageTransformer, + onEnd: CallbackAction + ): void { + /** + * Example of implementation: + this.customStore.get().then((pkg: Package) => { + updateHandler(pkg, function onUpdateFinish(err) { + if (err) { + onEnd(err); + } else { + onWrite(name, pkg, onEnd); + } + }) + }); + */ + } - public deletePackage(fileName: string, callback: Callback): void {} + /** + * Delete a specific file (tarball or package.json) + * @param fileName + * @param callback + */ + public deletePackage(fileName: string, callback: CallbackAction): void { + /** + * Example of implementation: + this.customStore.delete(fileName, (err) => { + if (err) { + callback(err); + } else { + callback(null); + } + }) + */ + } - public removePackage(callback: (err: Error | null) => void): void {} + /** + * Delete a package (folder, path) + * This happens after all versions ar tarballs have been removed. + * @param callback + */ + public removePackage(callback: CallbackAction): void { + /** + * Example of implementation: + this.customStore.removePackage((err) => { + if (err) { + callback(err); + } else { + callback(null); + } + }) + */ + } + /** + * Publish a new package (version). + * @param name + * @param data + * @param callback + */ public createPackage( name: string, - value: Package, - callback: Function - ): void {} + data: Package, + callback: CallbackAction + ): void { + /** + * Example of implementation: + * this.customStore.create(name, data).then(err => { + if (err.notFound) { + callback(getNotFound()); + } else if (err.alreadyExist) { + callback(getConflict()); + } else { + callback(null); + } + }) + */ + } - public savePackage(name: string, value: Package, callback: Function): void {} + /** + * Perform write anobject to the storage. + * Similar to updatePackage but without middleware handlers + * @param pkgName package name + * @param pkg package metadata + * @param callback + */ + public savePackage(pkgName: string, pkg: Package, callback: CallbackAction): void { + /* + Example of implementation: + this.cumstomStore.write(pkgName, pkgName).then(data => { + callback(null); + }).catch(err => { + callback(getInternalError(err.message)); + }) + */ + } - public readPackage(name: string, callback: Function): void {} + /** + * Read a package from storage + * @param pkgName package name + * @param callback + */ + public readPackage(pkgName: string, callback: ReadPackageCallback): void { + /** + * Example of implementation: + * this.customStorage.read(name, (err, pkg: Package) => { + if (err.fooError) { + callback(getInternalError(err)) + } else if (err.barError) { + callback(getNotFound()); + } else { + callback(null, pkg) + } + }); + */ + } - public writeTarball(name: string): UploadTarball {} + /** + * Create writtable stream (write a tarball) + * @param name + */ + public writeTarball(name: string): UploadTarball { + /** + * Example of implementation: + * const stream = new UploadTarball({}); + return stream; + */ - public readTarball(name: string): ReadTarball {} + } + + /** + * Create a readable stream (read a from a tarball) + * @param name + */ + public readTarball(name: string): ReadTarball { + /** + * Example of implementation: + * const stream = new ReadTarball({}); + return stream; + */ + } } diff --git a/generators/app/templates/typescript/storage/src/plugin.ts b/generators/app/templates/typescript/storage/src/plugin.ts index 05999104..db99f3e3 100644 --- a/generators/app/templates/typescript/storage/src/plugin.ts +++ b/generators/app/templates/typescript/storage/src/plugin.ts @@ -49,7 +49,9 @@ export default class VerdaccioStoragePlugin implements IPluginStorage { diff --git a/package.json b/package.json index f6300a86..849723fe 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,7 @@ "@types/yeoman-test": "^2.0.3", "@typescript-eslint/eslint-plugin": "^2.12.0", "@verdaccio/eslint-config": "^8.5.0", - "@verdaccio/types": "^8.5.0", + "@verdaccio/types": "^8.5.2", "eslint": "^6.7.2", "express": "^4.17.1", "get-stdin": "^7.0.0", diff --git a/yarn.lock b/yarn.lock index 772b8b6c..a0a8556c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -638,10 +638,10 @@ eslint-plugin-prettier "3.1.1" tsutils "3.17.1" -"@verdaccio/types@^8.5.0": - version "8.5.0" - resolved "https://registry.verdaccio.org/@verdaccio%2ftypes/-/types-8.5.0.tgz#b74de4ff3e0800a6878aea3e42000c139a4340c6" - integrity sha512-4+uBGbb0J+rmM74m7UNYGR3ps1MU3blZV1d5776l5L2xgizkuzClgb4owEgc+O3iWMkOIaLJ9jVSqow/WRVkhQ== +"@verdaccio/types@^8.5.2": + version "8.5.2" + resolved "https://registry.verdaccio.org/@verdaccio%2ftypes/-/types-8.5.2.tgz#4e371aae10e8550b4a19b57f6ba1f1f185147669" + integrity sha512-x/sacqVndl1dXVKPd7pomea6gs9BKC+i83LDn6MEAO+tuhqWRsKC3UwztLA1YSKjNF33//7JCYMDQk6uaJ9ipw== JSONStream@^1.0.4, JSONStream@^1.3.4, JSONStream@^1.3.5: version "1.3.5" From e3e654bbd4c8cedcfa9773da645cd4603155b608 Mon Sep 17 00:00:00 2001 From: "Juan Picado @jotadeveloper" Date: Wed, 25 Dec 2019 12:35:59 +0100 Subject: [PATCH 4/4] fix: test wrong file --- test/app.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/app.test.js b/test/app.test.js index 724f9c81..12f939d7 100644 --- a/test/app.test.js +++ b/test/app.test.js @@ -43,7 +43,7 @@ describe('generator-verdaccio-plugin app', function() { ), path.join( tempRoot, - `/verdaccio-plugin-${pluginType}-${name}/src/storageManager.js` + `/verdaccio-plugin-${pluginType}-${name}/src/index.js` ), path.join( tempRoot,