feat: add getSecret support

verdaccio · Jul 31, 2019 · 0d047f4 · 0d047f4
1 parent 6ca4e4f
commit 0d047f4
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 16 deletions.
diff --git a/plugins/memory/package.json b/plugins/memory/package.json
@@ -23,13 +23,12 @@
     "@commitlint/cli": "6.0.2",
     "@commitlint/config-conventional": "6.0.4",
     "@commitlint/travis-cli": "6.0.2",
-    "@verdaccio/types": "0.2.0",
+    "@verdaccio/types": "0.2.4",
     "babel-cli": "6.26.0",
     "babel-core": "6.26.0",
     "babel-eslint": "8.2.1",
     "babel-jest": "22.1.0",
     "babel-plugin-flow-runtime": "0.15.0",
-    "babel-plugin-istanbul": "4.1.5",
     "babel-plugin-transform-async-to-generator": "6.24.1",
     "babel-preset-env": "1.6.1",
     "babel-preset-flow": "6.23.0",

diff --git a/plugins/memory/src/local-memory.js b/plugins/memory/src/local-memory.js
@@ -1,26 +1,34 @@
 // @flow
 
 import MemoryHandler from './memory-handler';
-import type { LocalStorage, Logger, Config } from '@verdaccio/types';
+import type { Logger } from '@verdaccio/types';
 import type { ILocalData } from '@verdaccio/local-storage';
 
-export type ConfigMemory = Config & { limit?: number };
+export type ConfigMemory = { limit?: number };
+export type MemoryLocalStorage = { files: any, secret: string, list: any };
 
 const DEFAULT_LIMIT: number = 1000;
 class LocalMemory implements ILocalData {
   path: string;
   limit: number;
   logger: Logger;
-  data: LocalStorage;
-  config: Config;
+  data: MemoryLocalStorage;
+  config: ConfigMemory;
   locked: boolean;
 
   constructor(config: ConfigMemory, options: any) {
     this.config = config;
     this.limit = config.limit || DEFAULT_LIMIT;
     this.logger = options.logger;
     this.data = this._createEmtpyDatabase();
-    this.data.secret = config.checkSecretKey(this.data.secret);
+  }
+
+  getSecret(): string {
+    return this.data.secret;
+  }
+
+  setSecret(secret: string) {
+    this.data.secret = secret;
   }
 
   add(name: string) {
@@ -56,7 +64,7 @@ class LocalMemory implements ILocalData {
     return new MemoryHandler(packageInfo, this.data.files, this.logger);
   }
 
-  _createEmtpyDatabase(): LocalStorage {
+  _createEmtpyDatabase(): MemoryLocalStorage {
     const list: any = [];
     const files: any = {};
     const emptyDatabase = {

diff --git a/plugins/memory/src/memory-handler.js b/plugins/memory/src/memory-handler.js
@@ -7,7 +7,7 @@ import MemoryFileSystem from 'memory-fs';
 import { UploadTarball, ReadTarball } from '@verdaccio/streams';
 
 import type { HttpError } from 'http-errors';
-import type { StorageList, Package, Callback, Logger } from '@verdaccio/types';
+import type { StorageList, Callback, Logger } from '@verdaccio/types';
 import type { ILocalPackageManager } from '@verdaccio/local-storage';
 
 export const noSuchFile: string = 'ENOENT';
@@ -36,7 +36,8 @@ class MemoryHandler implements ILocalPackageManager {
   path: StorageList;
   logger: Logger;
 
-  constructor(packageName: string, data: StorageList, logger: Logger) {
+  constructor(packageName: string, data: any, logger: Logger) {
+    // this is not need it
     this.data = data;
     this.name = packageName;
     this.logger = logger;
@@ -166,7 +167,7 @@ class MemoryHandler implements ILocalPackageManager {
     return readTarballStream;
   }
 
-  _getStorage(name: string = ''): Package {
+  _getStorage(name: string = ''): string {
     return this.data[name];
   }
 }

diff --git a/plugins/memory/test/memory.spec.js b/plugins/memory/test/memory.spec.js
@@ -53,7 +53,7 @@ describe('memory unit test .', () => {
 
   describe('MemoryHandler', () => {
     test('should create an MemoryHandler instance', () => {
-      const memoryHandler: ILocalPackageManager = new MemoryHandler('test', pkgExample, { logger });
+      const memoryHandler = new MemoryHandler('test', pkgExample, logger);
 
       expect(memoryHandler).toBeDefined();
     });

diff --git a/plugins/memory/yarn.lock b/plugins/memory/yarn.lock
@@ -194,9 +194,9 @@
   version "1.0.0"
   resolved "https://registry.npmjs.org/@verdaccio/streams/-/streams-1.0.0.tgz#d5d24c6747208728b9fd16b908e3932c3fb1f864"
 
-"@verdaccio/[email protected].0":
-  version "0.2.0"
-  resolved "https://registry.npmjs.org/@verdaccio/types/-/types-0.2.0.tgz#bd12a9d0df832b123585741c0de43f361f742a99"
+"@verdaccio/[email protected].4":
+  version "2.0.5"
+  resolved "https://registry.npmjs.org/@verdaccio/types/-/types-2.0.5.tgz#a35682b0268a242c5fefded54f79a6b4d34dfa88"
 
 JSONStream@^1.0.4:
   version "1.3.2"
@@ -627,7 +627,7 @@ [email protected]:
     camelcase "^3.0.0"
     flow-config-parser "^0.3.0"
 
-babel-plugin-istanbul@4.1.5, babel-plugin-istanbul@^4.1.5:
+babel-plugin-istanbul@^4.1.5:
   version "4.1.5"
   resolved "https://registry.npmjs.org/babel-plugin-istanbul/-/babel-plugin-istanbul-4.1.5.tgz#6760cdd977f411d3e175bb064f2bc327d99b2b6e"
   dependencies: