Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fs.exists with other fileSystem alternatives #159

Merged

Conversation

shrirambalaji
Copy link
Contributor

@shrirambalaji shrirambalaji commented Oct 1, 2019

Type: chore
Scope: plugins/local-storage

The following has been addressed in the PR:

Description:

This PR removes our usage of fs.exists and replaces it with other file system API alternatives like fs.access and fs.stat.

Resolves #60

fs.exists is deprecated starting from node12.
fs.exists is deprecated starting from node 12
@shrirambalaji shrirambalaji changed the title Replace fs exists in node 12 Replace fs.exists with other fileSystem alternatives Oct 1, 2019
@juanpicado juanpicado self-requested a review October 3, 2019 07:42
@juanpicado
Copy link
Member

@sergiohgz I think the token just expired, it failed on publish

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #159 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   65.29%   65.29%   +<.01%     
==========================================
  Files          25       25              
  Lines        1386     1389       +3     
  Branches      198      199       +1     
==========================================
+ Hits          905      907       +2     
- Misses        479      480       +1     
  Partials        2        2
Flag Coverage Δ
#core 88.18% <ø> (ø) ⬆️
#plugins 58.48% <66.66%> (-0.06%) ⬇️
Impacted Files Coverage Δ
plugins/memory/src/memory-handler.ts 87.17% <88.88%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf4f89...bd3d96f. Read the comment docs.

@juanpicado juanpicado mentioned this pull request Oct 5, 2019
@juanpicado juanpicado merged commit f94e325 into verdaccio:master Oct 5, 2019
@juanpicado
Copy link
Member

Thanks guys !!

@juanpicado juanpicado added enhancement New feature or request hacktoberfest 🎃 labels Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest 🎃
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.exists is deprecated
4 participants