Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaling is failing in 1.27 clusters #191

Closed
okozachenko1203 opened this issue Aug 18, 2023 · 4 comments · Fixed by #192
Closed

Autoscaling is failing in 1.27 clusters #191

okozachenko1203 opened this issue Aug 18, 2023 · 4 comments · Fixed by #192
Assignees

Comments

@okozachenko1203
Copy link
Member

To support 1.27, we need to bump autoscaler chart to 9.29.1.

@okozachenko1203
Copy link
Member Author

Autoscaler1.27 is failing to get the list of machinepools because of perm lack. kubernetes/autoscaler@2c7c6c4

@okozachenko1203 okozachenko1203 self-assigned this Aug 18, 2023
@okozachenko1203
Copy link
Member Author

@mnaser

  • i think we have to consider the version upgrade for not only autoscaler but also other addons (like csi, ccm, cni, etc) which are maintained by mcapi driver.
  • Also i have another concern. It is that the available versions supported by mcapi could be limited by those addons' version compatibility matrix. To mitigate that, we could need to keep multiple versions of addons in mcapi.

What do you think?

@okozachenko1203 okozachenko1203 changed the title Upgrade autoscaler chart version to support k8s 1.27 Autoscaling is failing in 1.27 clusters Aug 22, 2023
@fnpanic
Copy link

fnpanic commented Aug 28, 2023

Checking for depracted APIs can be done with pluto,KubePug,KubeNoTrouble and kubent. This will help prevent this problems in the future and can be integrated in the CI workflow.

Checking the deprecation guide is a good idea anyway before declaring a version as stable:

https://kubernetes.io/docs/reference/using-api/deprecation-guide/

@mnaser
Copy link
Member

mnaser commented Aug 30, 2023

@okozachenko1203 i think this is the use case to look at this:

#74

if we implement the addons to be managed, this means we can use helm charts to deploy them and we can just use helm values to manage state/etc.

perhaps we can work on that effort first, and then we start managing those cluster addons at that point using the provider, and potentially even start moving the autoscaler into the cluster itself too and manage it via an addon provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants