Allow clients to limit the number of times a playlist attempts to reload following an error #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1098 +/- ##
==========================================
+ Coverage 86.41% 86.44% +0.02%
==========================================
Files 39 39
Lines 9465 9471 +6
Branches 2182 2183 +1
==========================================
+ Hits 8179 8187 +8
+ Misses 1286 1284 -2
Continue to review full report at Codecov.
|
…oad following an error
…oad following an error
evanfarina
force-pushed
the
efarina/configure_playlist_retry_count
branch
from
4360dc0 to
67bb93c
Compare
brandonocasey
previously approved these changes
Apr 29, 2021
gkatsev
previously approved these changes
May 5, 2021
|
The playback tests look a bit suspicious, they don't seem like the standard timeout issue we see. |
Co-authored-by: Gary Katsevman <[email protected]>
Co-authored-by: Gary Katsevman <[email protected]>
…ure_playlist_retry_count
gkatsev
previously approved these changes
Jun 9, 2021
gesinger
reviewed
Jun 10, 2021
gesinger
approved these changes
Jun 11, 2021
gkatsev
pushed a commit
that referenced
this pull request
Jun 22, 2021
Followup to #1098 where the default should've been Infinity, but it got lost in translation. Co-authored-by: Evan farina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the issue of unlimited retries mentioned in issue #983 by allowing clients to control how often a playlist will try to reload following an error. Thanks to @gkatsev for the suggestion of using the
playlistobject to keep track of number of retries.Specific Changes proposed
Introduce a new option
maxPlaylistRetrieswhich sets a limit on the number of times a playlist will be retried. Once the number of retries is greater than (>) the value set bymaxPlaylistRetries,playlist.excludeUntilis set toInfinity.Note: A property
retryCountis set and incremented onPlaylistobjects. I've found that playlist errors and segment errors follow different paths (playlistRequestErrorandblacklistCurrentPlaylist, respectfully) so I'm incrementing this property in each of these places. I'd appreciate it if a reviewer could confirm that no error will result in both of these methods being called as that would cause a single error to increment the retryCount twice.Requirements Checklist