fix: Skip flash-based source handler with DASH source #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Jan 16, 2018
test/videojs-http-streaming.test.js
Outdated
| type: 'aPplication/dAsh+xMl' | ||
| }), 'supports application/dash+xml'); | ||
| assert.notOk(HlsSourceHandler('flash').canPlayType('aPpLicAtion/DaSh+XmL'), | ||
| 'supports application/dash+xml'); |
There was a problem hiding this comment.
minor: should say doesn't support
gesinger
approved these changes
Jan 16, 2018
forbesjo
force-pushed
the
fix/no-flash-dash
branch
from
c6a5960 to
e4c1a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our Flash MSE cannot handle DASH content, skip over DASH sources.
Specific Changes proposed
Pass the source handler's mode to
canPlayTypeso the source can be rejected.Requirements Checklist