Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fmp4 captions regression #1434

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: fmp4 captions regression #1434

merged 1 commit into from
Oct 12, 2023

Conversation

adrums86
Copy link
Contributor

Description

Fixes an issue where caption data wasn't being passed out to the transmuxer callback for parsing.

Specific Changes proposed

Use the correctly scoped data object.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@adrums86 adrums86 self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1434 (e127b7c) into main (dd5e2af) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   85.98%   85.98%           
=======================================
  Files          42       42           
  Lines       10428    10428           
  Branches     2412     2412           
=======================================
  Hits         8967     8967           
  Misses       1461     1461           
Files Coverage Δ
src/media-segment-request.js 96.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew this had to be like a one line change! Nice find.

@adrums86 adrums86 merged commit fcd2e8a into main Oct 12, 2023
@adrums86 adrums86 deleted the fix-fmp4-captions branch October 12, 2023 16:10
dzianis-dashkevich pushed a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants