-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix regression: prevent wrapping in resetMainLoaderReplaceSegments #1439
Conversation
This fixes a regression introduced in 4590bdd If the quality is changed during initialization, this function is called. Since `buffered.length` is zero and `buffered` is a `TimeRanges`, `length` (an `unsigned long`) wraps around and becomes 4294967295
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
videojs/http-streaming#1439 Signed-off-by: Varun Patil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! LGTM.
Codecov Report
@@ Coverage Diff @@
## main #1439 +/- ##
=======================================
Coverage 85.94% 85.94%
=======================================
Files 42 42
Lines 10436 10436
Branches 2414 2415 +1
=======================================
Hits 8969 8969
Misses 1467 1467
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Congrats on merging your first pull request! 🎉🎉🎉 |
First of all thanks for the work you have been doing. We've been using video.js for some years and it's fantastic. Since we started using HLS we started to get some errors in sentry. I believe this commit fixes our issue. Can you please tell me when a new version will be released? Thanks
|
This reverts commit 719b7f4.
…rEachSegment and remove replaceSegmentsUntil (#1457) * Revert "fix: check for transmuxer for vtt-segment-loader (#1452)" This reverts commit b4dd748. * Revert "fix: fix several issues with calculate timestamp offset for each segment (#1451)" This reverts commit 3bbc6ef. * Revert "fix: replaceSegmentsUntil flag resetting too early (#1444)" This reverts commit af39ba5. * Revert "fix: prevent wrapping in resetMainLoaderReplaceSegments (#1439)" This reverts commit 719b7f4. * Revert "feat: Add feature flag to calculate timestampOffset for each segment to handle streams with corrupted pts or dts timestamps (#1426)" This reverts commit 2355ddc. * Revert "fix: fastQualityChange refactor (#1414)" This reverts commit 4590bdd. * cherry-pick: use transmuxer time info instead of probeTs * feat: sync controller media sequence strategy (#1458) * feat: add media sequence sync strategy * fix: fix current media sequence increment * chore: update logs * feat: use exact segment match in sync-controller * fix: fix race condition for a fast quality switch * chore: add additional logs for choose next request * feat: force timestamp after resync * chore: fix or skip tests * Update src/segment-loader.js Co-authored-by: Walter Seymour <[email protected]> --------- Co-authored-by: Dzianis Dashkevich <[email protected]> Co-authored-by: Walter Seymour <[email protected]> --------- Co-authored-by: Dzianis Dashkevich <[email protected]> Co-authored-by: Walter Seymour <[email protected]>
This fixes a regression introduced in 4590bdd
If the quality is changed during initialization, this function is called. Since
buffered.length
is zero andbuffered
is a TimeRanges,length
(anunsigned long
) wraps around and becomes4294967295