fix: enableFunction not passing playlist to fastQualityChange #1502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our rendition mixin
enableFunction
is used to select a rendition/variant for playback. This function uses the playlist controllerfastQualityChange_
to do this switch, however we were not passing the playlist during this call, resulting in inconsistent quality switches due to the next playlist coming from aselectPlaylist()
call instead of user selection.Specific Changes proposed
Pass playlist as a parameter during the
fastQualityChange_
/changePlaylistFn
callRequirements Checklist