Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check tech error before pause #969

Merged
merged 2 commits into from
Oct 2, 2020
Merged

fix: check tech error before pause #969

merged 2 commits into from
Oct 2, 2020

Conversation

brandonocasey
Copy link
Contributor

See #968

gesinger
gesinger approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@gesinger gesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be worth a comment, but code looks good

@brandonocasey brandonocasey force-pushed the 2.2-fix/check-tech-error branch from 8bf6b45 to 49183ca Compare October 2, 2020 17:13
@gkatsev gkatsev merged commit 248ee82 into 2.2.x Oct 2, 2020
@gkatsev gkatsev deleted the 2.2-fix/check-tech-error branch October 2, 2020 17:35
gkatsev pushed a commit that referenced this pull request Oct 2, 2020
@brandonocasey @gkatsev
fix: check tech error before pause loaders (#969)
0c7b2cb 
A failed poster image may trigger an error event from the tech. This shouldn't cause us to pause our loaders, though.
Instead, we should verify that there's an actual error object on the tech before proceeding with pausing the loaders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gesinger gesinger gesinger approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonocasey @gesinger @gkatsev