Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playbackRateMenu: div.vjs-menu not in vjs-control-content #1712

Closed
thxer opened this issue Dec 4, 2014 · 4 comments
Closed

playbackRateMenu: div.vjs-menu not in vjs-control-content #1712

thxer opened this issue Dec 4, 2014 · 4 comments
Labels
bug confirmed

Comments

@thxer
Copy link

thxer commented Dec 4, 2014

Hi,

playbackRateMenu generates div.vjs-menu with supported playback speed, but it need to append vjs-control-content to work popup menu
@mmcc mmcc added the question label Dec 4, 2014
@mmcc
Copy link
Member

mmcc commented Dec 4, 2014

I'm not following. Would you mind putting together a reduced test case that shows the issue you're seeing?

@mmcc mmcc added bug needs: reduced test case A reproducible test case is needed. See https://stackoverflow.com/help/minimal-reproducible-example and removed question labels Dec 4, 2014
@thxer
Copy link
Author

thxer commented Dec 4, 2014

I just added playbackRates option. Version 4.8 and before, its working, on mouse hover, the playback speed menu appear. After 4.9, its doesn't appear, only works clicks.
With videojs 4.8:
http://jsbin.com/bayutu/1/
With videojs 4.9:
http://jsbin.com/zoceq/1/

@mmcc mmcc added confirmed and removed needs: reduced test case A reproducible test case is needed. See https://stackoverflow.com/help/minimal-reproducible-example labels Dec 4, 2014
@mmcc
Copy link
Member

mmcc commented Dec 4, 2014

Hmmm...Interesting...I have no idea why this changed, but I'll look into it. Thanks for letting us know!

@mmcc
Copy link
Member

mmcc commented Dec 5, 2014

I just submitted a PR to fix this: #1716

@mmcc mmcc closed this as completed in bb5582a Dec 18, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmcc @thxer