fix: improved accessibility for time display #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to remove the aria-live attribute from time display elements. The aria-live attribute is no longer needed since the presentation role was added. Both attributes being present can lead to unexpected screen reader behavior. Fixes issue videojs#8143
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #8182 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 112 112
Lines 7402 7402
Branches 1785 1785
=======================================
Hits 6078 6078
Misses 1324 1324
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Makes sense to me. @OwenEdwards did you have anything to add on this?
misteroneill
approved these changes
Mar 21, 2023
|
Congrats on merging your first pull request! 🎉🎉🎉 |
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
This change is to remove the aria-live attribute from time display elements. The aria-live attribute is no longer needed since the presentation role was added. Both attributes being present can lead to unexpected screen reader behavior. Fixes issue videojs#8143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to remove the aria-live attribute from time display elements. The aria-live attribute is no longer needed since the presentation role was added. Both attributes being present can lead to unexpected screen reader behavior. Fixes issue #8143
Description
This PR fixes the accessibility bug described in #8143
Specific Changes proposed
Remove aira-live attribute from time display elements in the player. This attribute was originally added to prevent screen readers from announcing every time change, but later, role="presentation" was added. The presentation role will hide the element from the screen reader all together, so aria-live is no longer needed.
Requirements Checklist