feat: Improve SmartTV scrubbing behavior #8988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 18, 2025 15:46
- Replace direct access to `this.pendingSeekTime_` with a public getter/setter (`pendingSeekTime()`). - Update scrubbing logic in methods (getPercent, handleMouseMove, handleMouseUp, stepForward, stepBack, and handleAction) - Add support for SmartTV devices by integrating the new `disableSeekWhileScrubbingOnSTV` option. - Pass the event parameter to `bar.update()` in the update method.
- Added tests in `controls.test.js` to verify UI updates (progress bar & current-time display) - Added tests in `player.test.js` to validate SmartTV seek logic - Ensured `stepForward()` and `stepBack()` correctly update `pendingSeekTime` - Verified `handleAction()` finalizes the seek and resets `pendingSeekTime` - Fixed test for `disableSeekWhileScrubbingOnSTV = false` by recreating `SeekBar` instance
…smarttv-scrubbing
…y without confirmation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8988 +/- ##
==========================================
+ Coverage 84.13% 84.26% +0.13%
==========================================
Files 120 120
Lines 8117 8149 +32
Branches 1948 1965 +17
==========================================
+ Hits 6829 6867 +38
+ Misses 1288 1282 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the handling of pendingSeekTime to improve scrubbing behavior on SmartTVs. It introduces a more structured approach for handling seek updates, ensuring better UX for SmartTV users who navigate via remote controls.
Specific Changes proposed
Requirements Checklist
npm run docs:apito error