-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: call Logger for plugin logs in build #13757
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
The support for this.info
/this.debug
is needed too.
https://github.com/vitejs/vite/pull/13608/files#diff-c0b6eb176448702b6325d2e1b2567c5ccf969f03eef1242950e0bfb18877022fR192-R196
https://github.com/vitejs/vite/pull/13608/files#diff-c0b6eb176448702b6325d2e1b2567c5ccf969f03eef1242950e0bfb18877022fR412-R413
settings: { | ||
node: { | ||
version: '^18.0.0 || ^20.0.0 || >=22.0.0', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/vite/src/node/__tests__/package.json
was picked up for packages/vite/src/node/__tests__/build.spec.ts
by eslint-plugin-n and because that package.json does not have engines
field, >=16.0.0
was used and an lint error happened for util.stripVTCharacters
.
https://github.com/eslint-community/eslint-plugin-n?tab=readme-ov-file#configured-nodejs-version-range
I set this to make ^18.0.0 || ^20.0.0 || >=22.0.0
to be applied across the repo.
@sapphi-red |
Description
This PR contains feature of supporting Rollup logging function.
Originally, the Vite used onWarn to handle only warnings, but this pull request uses onLog to add handling for info, debug, and error log levels.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).