Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: call Logger for plugin logs in build #13757

Merged
merged 21 commits into from
Jan 23, 2025

Conversation

mato533
Copy link
Contributor

@mato533 mato533 commented Jul 9, 2023

Description

This PR contains feature of supporting Rollup logging function.
Originally, the Vite used onWarn to handle only warnings, but this pull request uses onLog to add handling for info, debug, and error log levels.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mato533 mato533 changed the title Feature/Support Rollup logging functions feat: Support Rollup logging functions Jul 10, 2023
@sapphi-red sapphi-red added enhancement New feature or request rollup plugin compat p3-significant High priority enhancement (priority) labels Jul 13, 2023
@mato533 mato533 changed the title feat: Support Rollup logging functions feat: support Rollup logging functions Jul 14, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sapphi-red sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) and removed rollup plugin compat p3-significant High priority enhancement (priority) labels Dec 9, 2024
@sapphi-red sapphi-red changed the title feat: support Rollup logging functions feat: call Logger for plugin logs Dec 9, 2024
@sapphi-red sapphi-red changed the title feat: call Logger for plugin logs feat: call Logger for plugin logs in build Dec 9, 2024
sapphi-red
sapphi-red previously approved these changes Dec 9, 2024
Comment on lines +53 to +57
settings: {
node: {
version: '^18.0.0 || ^20.0.0 || >=22.0.0',
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/vite/src/node/__tests__/package.json was picked up for packages/vite/src/node/__tests__/build.spec.ts by eslint-plugin-n and because that package.json does not have engines field, >=16.0.0 was used and an lint error happened for util.stripVTCharacters.
https://github.com/eslint-community/eslint-plugin-n?tab=readme-ov-file#configured-nodejs-version-range
I set this to make ^18.0.0 || ^20.0.0 || >=22.0.0 to be applied across the repo.

@sapphi-red sapphi-red added this to the 6.1 milestone Dec 11, 2024
@mato533
Copy link
Contributor Author

mato533 commented Dec 11, 2024

@sapphi-red
long time no see.
thank you for closing this PR!

@patak-dev patak-dev merged commit bf3e410 into vitejs:main Jan 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants