Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency picomatch to v4 #15876

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 12, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
picomatch ^2.3.1 -> ^4.0.2 age adoption passing confidence

Release Notes

micromatch/picomatch (picomatch)

v4.0.2

Compare Source

v4.0.1

Compare Source

v4.0.0

Compare Source

Fixes
Changed

v3.0.1

Compare Source

Fixes
  • Support stars in negation extglobs with expression after closing parenthesis #​102, thanks to @​mrmlnc

v3.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Feb 12, 2024
Copy link

stackblitz bot commented Feb 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member

bluwy commented Feb 12, 2024

We closed the v3 update due to #14799 (comment)

@sapphi-red
Copy link
Member

The new picomatch supports Node 12+.
The packages we use that depends on picomatch are:

micromatch 4.0.5
└── picomatch 2.3.1
fast-glob 3.3.2
└─┬ micromatch 4.0.5
  └── picomatch 2.3.1
@rollup/pluginutils 5.1.0
└── picomatch 2.3.1
@rollup/plugin-commonjs 25.0.7
└─┬ @rollup/pluginutils 5.1.0
  └── picomatch 2.3.1
@rollup/plugin-dynamic-import-vars 2.1.2
├─┬ @rollup/pluginutils 5.1.0
│ └── picomatch 2.3.1
└─┬ fast-glob 3.3.2
  └─┬ micromatch 4.0.5
    └── picomatch 2.3.1
@rollup/plugin-json 6.1.0
└─┬ @rollup/pluginutils 5.1.0
  └── picomatch 2.3.1
chokidar 3.6.0
├─┬ anymatch 3.1.2
│ └── picomatch 2.3.1
└─┬ readdirp 3.6.0
  └── picomatch 2.3.1

micromatch: currently supports Node 8.6+. Requires a major bump. PR already open
fast-glob: currently supports Node 16.14+. I guess it doesn't require a major bump.
@rollup/pluginutils: currently supports Node 14.0+. I guess it doesn't require a major bump.
anymatch: currently supports Node 8+. Requires a major bump.
readdirp: currently supports Node 8.10+. Requires a major bump. Though, the new major version released in beta doesn't have a glob feature.
chokidar: currently supports Node 8.10+. Requires a major bump.

@frandiox
Copy link
Contributor

The latest Picomatch version adds sideEffects: false to avoid bundling it when using ViteRuntime in workerd. If they release Micromatch with the latest Picomatch, it would be interesting to update both of them in Vite as well 👍

@sapphi-red
Copy link
Member

sapphi-red commented Feb 16, 2024

@frandiox The runtime API itself doesn't depend on micromatch/picomatch so I guess this PR isn't related. The reason I had this is because I used makeLegalIdentifier from @rollup/pluginutils.

@renovate renovate bot force-pushed the renovate/picomatch-4.x branch from 89abd9c to 0891828 Compare February 20, 2024 07:07
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch 2 times, most recently from f2c833c to 63ed021 Compare March 28, 2024 07:28
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch from 63ed021 to 0e7e1f5 Compare May 20, 2024 07:57
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch from 0e7e1f5 to c09eba3 Compare June 10, 2024 20:31
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch from c09eba3 to 98cd67c Compare June 18, 2024 07:06
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch from 98cd67c to 5c0710b Compare September 9, 2024 03:24
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch 2 times, most recently from aedaaab to 42510a2 Compare September 30, 2024 05:07
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch from 42510a2 to a091f83 Compare October 21, 2024 04:07
@renovate renovate bot force-pushed the renovate/picomatch-4.x branch from a091f83 to e2a615a Compare October 24, 2024 00:59
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since picomatch@4 is already pulled in, I think we can merge this one.

Copy link
Contributor Author

renovate bot commented Oct 24, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@bluwy bluwy merged commit 3774881 into main Oct 24, 2024
14 checks passed
@bluwy bluwy deleted the renovate/picomatch-4.x branch October 24, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants