-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css)!: remove default import in ssr dev #17922
Conversation
|
I think Vinxi and Remix are relying on default export of If this was meant to be deprecated already, then maybe it's okay to change though (also it might be just a one liner fix on their end?). |
Yeah it was deprecated in the previous major, and removed in this major (https://vitejs.dev/guide/migration.html#removed-deprecated-apis). Frameworks need to use |
/ecosystem-ci run |
📝 Ran ecosystem CI on
✅ analogjs, histoire, ladle, laravel, marko, previewjs, quasar, rakkas, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress |
Looks like astro, remix, and sveltekit all fails and likely related to the CSS handling, so this would be breaking then unfortunately. Let's move this to the next major then. |
/ecosystem-ci run |
📝 Ran ecosystem CI on
✅ analogjs, histoire, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress |
From the initial ecosystem-ci run, this affected astro, remix and sveltekit, so perhaps we should delay merging this until we can get them passing in |
The goal here is to bring vinxi > v0.5 css rendering back in line with v0.4.3. So this doesn't fix inconsistencies already existing from the v0.4.3 days. The new `cssUrlParamsWithoutSideEffects` and `injectQuery` functions are copied from Remix, opening up further future alignment of the used logic. Refs: b6d9643 1ac2df3 vitejs/vite#17922
The goal here is to bring vinxi > v0.5 css rendering back in line with v0.4.3. So this doesn't fix inconsistencies already existing from the v0.4.3 days. The new `cssUrlParamsWithoutSideEffects` and `injectQuery` functions are copied from Remix, opening up further future alignment of the used logic. Refs: b6d9643 1ac2df3 vitejs/vite#17922
Description
Found from withastro/astro#11811
In SSR dev, we still incorrectly support default imports of a CSS file (without queries). This feels like a bug fix, but technically I guess it affects frameworks like vitest that executes in SSR and serve mode?