fix(dynamicImportVars): correct glob pattern for paths with parentheses

[sunnylost]

Description

fixes #11824

In the transformDynamicImport method, the newRawPattern is generated using posix.relative(from, to). Since to is generated through toAbsoluteGlob(), if it contains parentheses, they will be escaped, resulting in an incorrect relative path when executed.

For example:

const from = 'src/routes/(app)/dir-1/[slug]'
const to = 'src/routes/\\(app\\)/dir-1/${params.slug}.svelte'

posix.relative(from, to) === '../../../\(app\)/dir-1/${params.slug}.svelte' // error
posix.relative(from, 'src/routes/(app)/dir-1/${params.slug}.svelte') === '../${params.slug}.svelte' // right

Since both parameters are valid paths when calling this method, parentheses should be allowed.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[bluwy]

The fix looks great 👍 Can we also add a test for this in playground/dynamic-import?

[sunnylost]

@bluwy Hi, I ran the tests on my Mac, and they all passed. I'm not sure why there's a failing on CI: Windows.

[sapphi-red]

I'm not sure why there's a failing on CI: Windows.

It seems there's two dist/assets/index-hash.js and the test is not picking up the right one for the failing test. Changing the file name of playground/dynamic-import/(app)/index.js to something else like playground/dynamic-import/(app)/main.js should fix the fail.

[sapphi-red]

Given that the problem is that toAbsoluteGlob escaping the characters unnecessary, how about not using that function?
Checking the toAbsoluteGlob function, most of the code is handling about globs and escaping the paths. I think it would be trimmed down to:

// replace `normalizeGlobPattern` + `toAbsoluteGlob` with
const dir = importer ? dirname(importer) : root
const normalized = rawPattern[0] === '/' ? posix.join(root, rawPattern.slice(1)) : posix.join(dir, rawPattern)

// pass it to `newRawPattern`
let newRawPattern = posix.relative(posix.dirname(importer), normalized)

[sunnylost]

OK, I'll fix this.

[sapphi-red]

Thank you!

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on e80a049: Open

suite	result	latest scheduled
analogjs	✅ success	❌ failure
histoire	❌ failure	❌ failure
redwoodjs	❌ failure	✅ success
remix	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
vike	❌ failure	❌ failure

✅ astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress

[patak-dev]

/ecosystem-ci run redwoodjs

[vite-ecosystem-ci]

📝 Ran ecosystem CI on e80a049: Open

✅ redwoodjs