Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move glob test root to reduce snapshot change #18053

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

sapphi-red
Copy link
Member

Description

Moved glob test root to reduce snapshot diff when adding unit tests for other plugins.

For example, #17589 adds packages/vite/src/node/__tests__/plugins/terser.spec.ts and that causes the glob test to fail: https://github.com/vitejs/vite/actions/runs/10749825079/job/29815203095#step:11:126
I think this is confusing for new contributors.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 9, 2024
Copy link

stackblitz bot commented Sep 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 04d7e77 into vitejs:main Sep 9, 2024
12 checks passed
@sapphi-red sapphi-red deleted the test/move-root-for-glob-test branch September 9, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants