-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update esbuild #18173
chore(deps): update esbuild #18173
Conversation
|
/ecosystem-ci run |
📝 Ran ecosystem CI on
✅ analogjs, astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, sveltekit, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress |
@bluwy @sapphi-red do you think we can get this backported to the v5 branch? I think we could release a v5.5 minor for this (but without doing any announcements). |
Isn't dropping OS support a breaking change? I know that we accept esbuild breaking changes sometimes, but this seems big enough that affected users can only workaround this by pinning the vite version. |
@bluwy Reading https://go.dev/doc/go1.20#windows and https://go.dev/doc/install/source#environment, I'm starting to wonder if there was a miss-interpretation from my part. As in support got dropped to "run" the go compiler on those platforms as opposed to target them. In which case, there wouldn't be any impact here. That said, I don't have any Windows 8 or mac with macOS 10.15 Catalina or older to verify this hypothesis. |
I think we can't do it for the reasons bluwy said. @Nemikolh |
Thanks for the insights @bluwy @sapphi-red 🙏🏼 |
Description
This PR updates
esbuild
to0.24.0
which is needed to fix stackblitz/webcontainer-core#1310 for good (note that in the meantime one can add anoverrides
orresolutions
field to their package.json to pick up that newer version ofesbuild
.For the curious, the underlying issue was a bug in the Go compiler: golang/go#65571.
Important changes coming with this release
0.22.0
,go
(and thusesbuild
) dropped support for the following operating system:0.24.0
,go
(and thusesbuild
) dropped support for the following operating system: