Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space is added after comma in data uris in srcsets #18454

Closed
7 tasks done
riw opened this issue Oct 24, 2024 · 1 comment
Closed
7 tasks done

space is added after comma in data uris in srcsets #18454

riw opened this issue Oct 24, 2024 · 1 comment

Comments

@riw
Copy link

riw commented Oct 24, 2024

Describe the bug

when a data uri of the form 'data:image/svg+xml;utf8,...' is used in srcsets vite adds a space after the comma like 'data:image/svg+xml;utf8, ...'

Reproduction

https://stackblitz.com/edit/vitejs-vite-ykknzg?file=index.html

Steps to reproduce

No response

System Info

System:
    OS: macOS 14.6.1
    CPU: (12) arm64 Apple M2 Max
    Memory: 179.67 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.1 - ~/.nvm/versions/node/v20.15.1/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.7.0 - ~/.nvm/versions/node/v20.15.1/bin/npm
    pnpm: 8.6.2 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 130.0.6723.59
    Safari: 17.6
  npmPackages:
    vite: ~6.0.0-beta.2 => 6.0.0-beta.2

Used Package Manager

npm

Logs

No response

Validations

@sapphi-red
Copy link
Member

This is already fixed by #18242. It is released since 6.0.0-beta.3.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants