Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define in environment config was not working #18515

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: define in environment config was not working #18515

merged 1 commit into from
Oct 30, 2024

Conversation

sapphi-red
Copy link
Member

Description

Passing define to environment config was not working.

@sapphi-red sapphi-red added feat: environment API Vite Environment API p3-minor-bug An edge case that only affects very specific usage (priority) labels Oct 30, 2024
bluwy
bluwy approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per-environment state in the client injections plugin is a bit weird to me, but I guess it helps Vitest importing /@vite/env in the server.

@patak-dev
Copy link
Member

Nate also needed it for One.

@patak-dev patak-dev merged commit 052799e into vitejs:main Oct 30, 2024
17 checks passed
@sapphi-red sapphi-red deleted the fix/define-in-environment-not-working branch October 30, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: environment API Vite Environment API p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphi-red @patak-dev @bluwy