Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update filename regex #18593

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

sapphi-red
Copy link
Member

Description

This PR improves the robustness of the test. The previous regex might fail if the hash contains -. It happened to contain - when I tried rolldown.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Nov 6, 2024
@patak-dev patak-dev merged commit dd25c1a into vitejs:main Nov 6, 2024
17 checks passed
@sapphi-red sapphi-red deleted the test/improve-filename-regex branch November 6, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants