-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($theme-default): improve last-updated text color contrast #2282
Conversation
On the `.last-updated .time` element, the color contrast is too low which raised an accessibility warning in a Lighthouse report. Minor tweak of the color to fix that.
Thanks! I changed the title since we use |
Yes ok, got it! 👍 |
@Mister-Hope yep, on your PR the contrast is still too low to reach the accessibility standard. If you use Chrome, simply open the dev tools, find the color in the css and click on the colored square. You'll see the contrast ratio (that you can expend) and see if it matches the minimum ratio. (as in the above screenshot) So the minimum value is still |
Thanks, I will make a commit later. |
@newsbielt703 I prefer to take this PR as a |
@meteorlxy Yeah it should be. |
Summary
On the
.last-updated .time
element, the color contrast is too low which raised an accessibility warning in a Lighthouse report.Here is a minor tweak of the color to fix that.
It won't affect much the end user, but provides:
What kind of change does this PR introduce? (check at least one)
Style
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
If we want to support a contrast ratio AAA we would need to update the color to at least:
#595959
. But the end result doesn't work as the time seems as black as the text. That's why, going for a contrast ratio AA is sufficient.