Update shaderc to 0.6 in order to significantly reduce compile-times … #1226
Conversation
…on (Arch/Void)Linux again by linking towards shared libraries
|
@Abendstolz nice! I think using pre-installed libraries was already active in 0.5, but at least this gets it working again on Arch and Void 👍 Could you also add a |
…build from source if linking to system libraries fails
|
@mitchmindtree sure thing. Done in 5db99c8 |
|
Thanks a lot @Abendstolz - it looks like travis is just complaining about some trailing whitespace now, but after that's fixed I'd be happy to merge! @rukai would you mind if we published 0.14 after this as another emergency patch to make it possible for Arch/Void users to build vulkano-shaders? Maybe we can also include #1227 and #1225, though I'm not well versed enough to understand if #1225 is correct/safe. Edit: Oh also now that I've merged #1225 we'll need to fix the conflict in the CHANGELOG. |
|
Sure, feel free to publish 0.14 if need be, the website would additionally need to be updated. I cannot review PRs as i am already using my free time to work on gfx Hal/wgpu stack. Sorry. It might be a simple change but it's hard to tell without investing a lot of time in the first place. |
|
@rukai I'd like to see this go through and a version published, my projects are still on vulkano 11.1 due to the linking errors with shaderc. That issue is solved by this pull request. |
|
can this be emergency pushed? basically all vulkano projects are broken now on archlinux et. al |
|
You can workaround it by adding the build-from-source feature to shaderc. As I have done here https://github.com/rukai/PF_Sandbox/blob/master/pf_sandbox/Cargo.toml Can @Abendstolz fix the CI errors? Then I can proceed with an emergency release |
|
@rukai or @mitchmindtree go for it ;) |
This is kind of a delayed emergency release to address an issue where some Linux distributions (Arch, Void and perhaps others) are unable to build any projects depending on vulkano-shaders due to google/shaderc-rs#58. This is resolved in shaderc 0.6 and in turn will be resolved in vulkano 0.14 thanks to vulkano-rs#1226. See the CHANGELOG-VULKANO.md for more details on the release.
This is kind of a delayed emergency release to address an issue where some Linux distributions (Arch, Void and perhaps others) are unable to build any projects depending on vulkano-shaders due to google/shaderc-rs#58. This is resolved in shaderc 0.6 and in turn will be resolved in vulkano 0.14 thanks to vulkano-rs#1226. See the CHANGELOG-VULKANO.md for more details on the release.
This is kind of a delayed emergency release to address an issue where some Linux distributions (Arch, Void and perhaps others) are unable to build any projects depending on vulkano-shaders due to google/shaderc-rs#58. This is resolved in shaderc 0.6 and in turn will be resolved in vulkano 0.14 thanks to #1226. See the CHANGELOG-VULKANO.md for more details on the release.
…on (Arch/Void)Linux again by linking towards shared libraries
CHANGELOG_VULKANO.mdorCHANGELOG_VK_SYS.mdif knowledge of this change could be valuable to users@mitchmindtree fyi