Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails on node v4.x #94

Closed
deckar01 opened this issue Sep 11, 2015 · 1 comment
Closed

Build fails on node v4.x #94

deckar01 opened this issue Sep 11, 2015 · 1 comment

Comments

@deckar01
Copy link

Issue
node-gyp fails to build odbc_result.cpp on node v4.x.

Cause
#93 Seems to identify part of the problem, v4.x NAN changes are not supported yet, although there may be other breaking changes.

Expected Behavior
The node engine version should be configured in package.json to prevent npm from trying build and to generate a useful error message.
@deckar01 deckar01 mentioned this issue Sep 11, 2015
Closed
@wankdanker
Copy link
Collaborator

Added node < 4.0.0 restriction in package.json in v1.1.8 on npm.

Thank you.

clach04 referenced this issue in clach04/node-odbc__DO_NOT_USE Dec 17, 2020
@gordonthorpe
Allocate error text buffer in GetODBCErrors() (wankdanker#94)
81c4af9 
Signed-off-by: gordonthorpe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wankdanker @deckar01