Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: handle errors generated in gm.rootTracker.UpdateLatestRoot(pair.Key.(uint64)) #738

Closed
richard-ramos opened this issue Sep 14, 2023 · 1 comment · Fixed by #873
Closed

bug: handle errors generated in gm.rootTracker.UpdateLatestRoot(pair.Key.(uint64)) #738

richard-ramos opened this issue Sep 14, 2023 · 1 comment · Fixed by #873
Assignees
@richard-ramos
Labels
bug Something isn't working E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details

Comments

@richard-ramos
Copy link
Member

richard-ramos commented Sep 14, 2023 •
edited
Loading

In #726 (comment) it was reported that an error updating the latest root should be considered critical. A failure in this function means that interacting with RLN failed, so we will probably end up with an inconsistent merkle tree
@richard-ramos richard-ramos added the E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details label Sep 14, 2023
@fryorcraken fryorcraken added this to Waku Sep 14, 2023
@richard-ramos richard-ramos mentioned this issue Sep 14, 2023
Merged
@richard-ramos richard-ramos self-assigned this Sep 14, 2023
@chair28980 chair28980 moved this to Priority in Waku Oct 31, 2023
@chair28980 chair28980 added the bug Something isn't working label Oct 31, 2023
@richard-ramos richard-ramos mentioned this issue Nov 7, 2023
Merged
@github-project-automation github-project-automation bot moved this from Priority to Done in Waku Nov 9, 2023
@richard-ramos
Copy link
Member Author

Weekly Update

  • achieved: task complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-ramos richard-ramos

Labels
bug Something isn't working E:3.2: Basic DoS protection in production See https://github.com/waku-org/pm/issues/70 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: panic if it is not possible to obtain the merkle root waku-org/go-waku
2 participants
@richard-ramos @chair28980