feat: ability to manually specify additional multiaddrs

[mfw78]

Problem

As a node operator, if I have followed the 'listening on websocket to enable connections with waku v2 browser peers tutorial, my node will not advertise wss on disc.

This is a problem in all cases where SSL termination is handled upstream of the nwaku / websockify node combination, such as:

• Kubernetes deployments using ingress proxies.
• Dappnodes (my case) that use an NGINX HTTPS proxy that abstracts away SSL termination / letsencrypt / DNS config.

Suggested solution

Provide a configuration option (CLI and environment variable) that allows for manually specifying additional multiaddrs that are to be advertised on disc protocols.

Alternatives considered

It was also considered to use the --websocket-support:true flag for normal ws (albeit on port 8000), though in this configuration, using the light-js client to attempt to dial the node (being behind a dappnode's HTTPS NGINX proxy, forwarded to the websocket port of 8000), the light-js client failed to dial. It was determined that only with websockify forwarding to port 60000 on nwaku was I able to dial using light-js.

Nonetheless, this alternative would still not solve the issue of correctly advertising wss and ws on the correct IANA-specified ports.

Acceptance criteria

For this feature to be deemed accepted, a node operator should be able to:

• Specify additional multiaddrs on which their node is dialable (ws, and wss).

[jm-clius]

Thanks for this issue!

[alrevuelta]

Not sure if we can close this? see comment

[jm-clius]

Indeed. Re-opening.

[rymnc]

The PR autoclosed it :/