Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(postgres): keep the Postgres queries in separate raw files. #1841

Closed
Tracked by #1888
Ivansete-status opened this issue Jul 5, 2023 · 1 comment
Closed
Tracked by #1888

chore(postgres): keep the Postgres queries in separate raw files. #1841

Ivansete-status opened this issue Jul 5, 2023 · 1 comment
Labels
E:PostgreSQL See https://github.com/waku-org/pm/issues/84 for details

Comments

@Ivansete-status
Copy link
Collaborator

Details

Keep the sql queries in external .sql plain text files ( #1764 (comment) ) . Also, important to pay attention to the @LNSD comment: #1590 (comment)

Related issue

#1604
@Ivansete-status Ivansete-status mentioned this issue Jul 5, 2023
Closed
5 tasks
@SionoiS SionoiS moved this to Icebox in Waku Jul 25, 2023
@Ivansete-status Ivansete-status mentioned this issue Aug 7, 2023
Closed
8 tasks
@fryorcraken fryorcraken added the E:PostgreSQL See https://github.com/waku-org/pm/issues/84 for details label Sep 8, 2023
@fryorcraken fryorcraken mentioned this issue Sep 8, 2023
Closed
8 tasks
@Ivansete-status
Copy link
Collaborator Author

I disregard for now this point. The main reason is that we are using prepared statements intensively, in order to enhance query performance, and that induced a more complex query set. Therefore, I don't see a benefit of doing that in the short-term.

@Ivansete-status Ivansete-status closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:PostgreSQL See https://github.com/waku-org/pm/issues/84 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fryorcraken @Ivansete-status