-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENR waku2 field always sets relay
to true and others to false
#951
Comments
Here are a couple of sample encoded by js-waku to help finding the issue: all fields set to
only relay set to
only store set to
|
js-waku bug. |
In the logs you showed, I can only find a DNS ENR, so I assume discv5 was not active. The ENRs are Relay + Store
All
Relay only
These all contain the respective flags. What was the full cmd you ran? |
discv5 discovery was not active. Apologies for the waste of time, if it was a fundamental issue on js-waku side. Now fixed and merged. |
When trying different combination of the
--relay
,--store
,--lightpush
and--filter
parameters withwakunode
v0.9, it seems that the ENR URI displayed in the logs and returned in theinfo
JSON RPC API always set thewaku
field torelay=true
and the rest false.There are extensive ENR testing in js-waku so I am starting to think the issue is on nwaku side.
See here the test cases against nwaku: https://github.com/status-im/js-waku/blob/11e6f91036563ca415bca8661a9da0a98bcabb8e/src/lib/enr/enr.node.spec.ts
Both
Relay + Store
andAll
test cases fail because the result isrelay: true
and the rest false.nwaku_ENR_Interop_nwaku_All.log
nwaku_ENR_Interop_nwaku_Relay.log
nwaku_ENR_Interop_nwaku_Relay_+_Store.log
The text was updated successfully, but these errors were encountered: