Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.livinnsharonville.com - see bug description #8091

Closed
webcompat-bot opened this issue Jul 8, 2017 · 7 comments
Closed

www.livinnsharonville.com - see bug description #8091

webcompat-bot opened this issue Jul 8, 2017 · 7 comments

Comments

@webcompat-bot
Copy link

URL: http://www.livinnsharonville.com/
Problem type: Something else
Description: Reservation section doesn't work properly - calendar doesn't pop up to select dates
Steps to Reproduce 1. I went to the URL
2. I clicked on the "Book" icon on the top left hand corner
3. The reservation section popped up on the screen
4. I tried to select arrival and departure dates in the two date boxes
5. The calendar did not pop up for either (it did in Chrome when I tried it there), and when I tried to manually type in the dates the reservation section disappeared and the main page was displayed

Browser / Version: Firefox Mobile 55.0
Operating System: Android 7.1.1
Tested Another Browser: Yes

From webcompat.com with ❤️

@MDTsai
Copy link

MDTsai commented Jul 10, 2017

Confirmed, I can reproduce this issue using Firefox mobile 56. Click on date shows the virtual keyboard, but the date input field disappears. Move to needsdiagnosis.

@karlcow
Copy link
Member

karlcow commented Mar 15, 2018

from https://www.livinnsharonville.com/dynamic/js/mobile.aspx

/********************** START: MOBILE Booking  ***********************/

var toDay = getTodayDateFromPC("yyyy-mm-dd");
var tomorowDate = getTodayDateFromPC("yyyy-mm-dd", 1);
$(document).ready(function() {  

    if (document.getElementById('mob-checkindate')) {
        $('#mob-checkindate').val(getTodayDateFromPC("yyyy-mm-dd"));
        $('#mob-checkindate').attr("min",getTodayDateFromPC("yyyy-mm-dd"));
    }
    if (document.getElementById('mob-checkoutdate')) {
        $('#mob-checkoutdate').val(getTodayDateFromPC("yyyy-mm-dd", 1));
        $('#mob-checkoutdate').attr("min",getTodayDateFromPC("yyyy-mm-dd", 1));
    }

     $("#mob-checkindate").change(function(event) {
		if($(this).val() != "") {
			currentDate = $(this).val();
			if(toDay <= currentDate) {
			$("#mob-checkoutdate").val(addSubtractDate(currentDate, 1));
			$("#mob-checkoutdate").attr("min",addSubtractDate(currentDate, 1));
			} else {
			resetDate();
			}        
		} else {
			resetDate();
		}
    });

    $("#mob-checkoutdate").change(function(event) {
		if($(this).val() != "") {
			checkInDate = $("#mob-checkindate").val();
			currentDate = $(this).val();
			if(tomorowDate <= currentDate) {
			   if(currentDate <= checkInDate) {
				   $("#mob-checkindate").val(addSubtractDate(currentDate, -1));
			   }        
			} else {
			   resetDate();
			}         
		} else {
			resetDate();
		}
    });
	
	setInterval(function(){
		if($("#mob-checkoutdate").val() == "" || $("#mob-checkindate").val() == "") {
			 resetDate();
			}
		},100);
	});
	

@karlcow
Copy link
Member

karlcow commented Mar 15, 2018

That looks like a bit the issue in #7294
And whatwg/html#3232

@karlcow
Copy link
Member

karlcow commented Mar 15, 2018

@wisniewskit What do you think?

@wisniewskit
Copy link
Member

@karlcow whatever it is, it's fixed by Stylo/Quantum CSS being enabled soon on Android Firefox. That is, the site doesn't work for me on 59/stable, but does on the nightly or beta builds (unless I disable Stylo, at which point I get the same result as I do on 59). I'm not sure if it's worth doing a more advanced diagnosis if it will be fixed in the next Firefox release. Thoughts?

@karlcow
Copy link
Member

karlcow commented Mar 19, 2018

So working on beta/nightly on Firefox Android. Not fully closing yet as worksforme, but let's verify and eventually close when released.

@karlcow
Copy link
Member

karlcow commented May 14, 2018

This is working for me now.

@karlcow karlcow closed this as completed May 14, 2018
@karlcow karlcow modified the milestones: needsdiagnosis, worksforme May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants