Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default range +1 day #74

Closed
karlcow opened this issue Jun 25, 2018 · 3 comments
Closed

Make the default range +1 day #74

karlcow opened this issue Jun 25, 2018 · 3 comments

Comments

@karlcow
Copy link
Member

karlcow commented Jun 25, 2018

Not sure if it's a question of TZ. :)
but in Japan at least, if I enter https://webcompat.github.io/webcompat-metrics-client/

I get https://webcompat.github.io/webcompat-metrics-client/?from=2018-05-25&to=2018-06-25

right now it is 12:29 JST

capture d ecran 2018-06-25 a 12 30 09

it seems to show the data until June 24 at 24:00

if I change the date to be tomorrow aka https://webcompat.github.io/webcompat-metrics-client/?from=2018-05-25&to=2018-06-26

I get the data from 25 00:00 JST to 25 12:29 JST

capture d ecran 2018-06-25 a 12 33 08

or zooming in a bit.

"Default"
capture d ecran 2018-06-25 a 12 35 27

Now
capture d ecran 2018-06-25 a 12 35 46

@magsout
Copy link
Member

magsout commented Jun 30, 2018

I guess is something about UTC iamkun/dayjs#168

@prantlf
Copy link

prantlf commented Sep 5, 2018

@karlcow , you want to use only the date part of the dayjs object, but you initialise it with the full date + time. The time part in the local time zone causes the occasional shift of the day. I commented about it at #249.

Having a date-only mode in Day.js, or an UTC mode as a workaround will make the usage easier. Until then, you need to be aware and deal with the full date + time value, as you would, if you used the plain JavaScript date.

@magsout
Copy link
Member

magsout commented Nov 5, 2018

@magsout magsout closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants