-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt/Share overlay implementation with create-react-app? #184
Comments
Integrating the error overlay should be as simple as adding it as an entrypoint to webpack (or just requiring it somewhere -- it has a global side-effect). If interest is this high for it, it's probably worth releasing as a separate package but I think we want to keep it contained in |
I agree I'd like to have it standalone and pull it in. It would be nicer to be outside dev-utils but I don't think that's a huge issue as this is a dev-only package anyway. |
Could someone clarify the goal for this issue? From what I have read, I would assume you all want to replace the existing overlay with Getting the overlay to work in webpack-hot-middleware (whm) is as simple as this now that it is standalone. Alternatively if you just want it to work alongside whm you can add |
With |
I'm using webpack-hot-middleware for a project and I noticed the overlay(which is quite good) and recently found out about this which is amazing and wondering if maybe we could replicate the effort on the overlay that this middleware already provides. Since both are build on webpack could it be possible to copy paste the overlay they created? @Timer may know more about this and if it's possible.
The text was updated successfully, but these errors were encountered: