From 7a815e288af89d575eab041b6ea04fc1e47b2f92 Mon Sep 17 00:00:00 2001 From: Lars Kappert Date: Sun, 18 Feb 2024 19:17:02 +0100 Subject: [PATCH] Return undefined if no manifest (shouldn't happen anyway) --- packages/knip/src/ConfigurationChief.ts | 2 +- packages/knip/src/index.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/knip/src/ConfigurationChief.ts b/packages/knip/src/ConfigurationChief.ts index 8163220b3..f4dab8577 100644 --- a/packages/knip/src/ConfigurationChief.ts +++ b/packages/knip/src/ConfigurationChief.ts @@ -365,7 +365,7 @@ export class ConfigurationChief { } public getManifestForWorkspace(dir: string) { - return this.availableWorkspaceManifests?.find(item => item.dir === dir)?.manifest ?? {}; + return this.availableWorkspaceManifests?.find(item => item.dir === dir)?.manifest; } public getIncludedWorkspaces() { diff --git a/packages/knip/src/index.ts b/packages/knip/src/index.ts index 811c78ffd..bcbf48461 100644 --- a/packages/knip/src/index.ts +++ b/packages/knip/src/index.ts @@ -145,6 +145,8 @@ export const main = async (unresolvedConfiguration: CommandLineOptions) => { const manifest = chief.getManifestForWorkspace(dir); const { ignoreBinaries, ignoreDependencies } = chief.getIgnores(name); + if (!manifest) continue; + deputy.addWorkspace({ name, cwd, dir, manifestPath, manifest, ignoreBinaries, ignoreDependencies }); const dependencies = deputy.getDependencies(name);