Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DeckTape Docker printing instructions to README #345

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Added DeckTape Docker printing instructions to README #345

merged 2 commits into from
Oct 16, 2020

Conversation

mtoohey31
Copy link
Contributor

Feel free to make changes if you'd like, I think the instructions are reasonably clear though.

@webpro
Copy link
Owner

webpro commented Oct 11, 2020

Thanks @Ninja73737!

When I try it, I get this:

 ❯ ./bin/reveal-md.js demo/a.md 
Reveal-server started at http://localhost:1948
❯ docker run --rm -t --net=host -v foo:/slides astefanutti/decktape http://localhost:1948/a.md a.pdf
Loading page http://localhost:1948/a.md ...

Unable to load resource from URL: http://localhost:1948/a.md

Error: net::ERR_CONNECTION_REFUSED at http://localhost:1948/a.md

Am I missing something?

@mtoohey31
Copy link
Contributor Author

mtoohey31 commented Oct 11, 2020

Hmm that's odd... It appears correct to me, is http://localhost:1948/a.md the full url though or is there a #/ ending when you view it in your browser? That's the only thing I can think of, cause it looks like a networking issue, but you've used --net=host so the only thing I can think of is the url...

@webpro
Copy link
Owner

webpro commented Oct 11, 2020

When I add the hash it's stripped off anyway:

❯ docker run --rm -t --net=host -v foo:/slides astefanutti/decktape http://localhost:1948/a.md#/ a.pdf
Loading page http://localhost:1948/a.md#/ ...

Unable to load resource from URL: http://localhost:1948/a.md

Error: net::ERR_CONNECTION_REFUSED at http://localhost:1948/a.md#/

Sorry, I'm not a Docker expert :)

@mtoohey31
Copy link
Contributor Author

No worries, neither am I. I don't have access to a computer where I can run docker rn, so I can't troubleshoot, on Monday I should be able to though.

If you want to in the meantime though you could see if the issue still happens when you're running reveal-md through Docker too.

@mtoohey31
Copy link
Contributor Author

Figured it out! The issue is that you can't use the localhost portion of the URL when you're running DeckTape from Docker and reveal-md locally, not in Docker. There are no issues when reveal-md is also running in Docker. I also checked whether or not the --host arg matters for reveal-md, and it doesn't seem to make a difference, so I added an edit to the pull request suggesting that users change the localhost portion of the URL to the IP address of their computer when running DeckTape in Docker and reveal-md locally.

Let me know if there's any other issues you run into!

@webpro webpro merged commit d303a34 into webpro:master Oct 16, 2020
@webpro
Copy link
Owner

webpro commented Oct 16, 2020

Thank you, @Ninja73737! Works like a charm. I'm sure it will help folks out 👍

@webpro
Copy link
Owner

webpro commented Oct 16, 2020

By the way, I did refactor the text a little bit, hope you are OK with it :)

@mtoohey31
Copy link
Contributor Author

Great, glad to help! And definitely no problem with changing the wording!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants