fix(print-pdf): wait untill all resources are loaded #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue with the loading of js assets and custom fonts when attempting to generate a PDF. This resulted in either empty or poorly formatted pdf. Upon investigation, I determined that the problem was related to the
waitUntil
option of Puppeteer'sgoto()
method.There are several options available for the
waitUntil
parameter, includingload
,domcontentloaded
,networkidle0
, andnetworkidle2
. You can find detailed descriptions of these options here and a discussion in this GitHub issue.I changed the
waitUntil
value tonetworkidle0
, and this adjustment successfully resolved the problem, allowing the assets and fonts to load properly before generating pdf