Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de-duplicate IP packages #2821

Open
ThaUnknown opened this issue Jun 29, 2024 · 2 comments
Open

de-duplicate IP packages #2821

ThaUnknown opened this issue Jun 29, 2024 · 2 comments
Labels
accepted

Comments

@ThaUnknown
Copy link
Member

What problem do you want to solve?
Webtorrent uses 5 different IP parsing packages.
What do you think is the correct solution to this problem?
De-dupe them.
Are you willing to submit a pull request to implement this change?
ya
@cap-code
Copy link

is this done or still in progress?

@ThaUnknown
Copy link
Member Author

its untouched because it's one of those things you really don't want to fuck up, and its benefits are small, less than 3kb of bundle reducement, which is less than 30ms of loading time iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThaUnknown @cap-code