-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome-settings-daemon detection doesn't work outside of i3, GNOME, or XFCE #61
Comments
The portal implementation (#51) has indeed been worked on but stalled due to unknown limitations in the IDEA platform, which haven't been resolved yet by the looks of it. Detecting whether the current implementation works isn't trivial as there is no unified way of checking it without running it and seeing if it doesn't fail (which I really don't want to do). Now what I can imagine doing is adding an "I am absolutely sure my system supports the plugin, I know what I a doing" option to force the current implementation to be used. It's not ideal but the probably quickest solution. |
Yeah, I think the best option to check if I don't know exactly what direction Linux is going for this. I've been using darkman which offers some cross implementation compatibility and allows running arbitrary scripts to fix all the things that don't use a "standard" interface. I think that'll be what I have to do for the next 2-3 years at least. |
This plugin does not work with Gnome 43. |
I currently don't have a lot of time for working on this plugin. I would be happy for any contributions tackling this. |
I have prepared a new version, which might fix this: #50 (comment) |
Closing this as the remaking issue with Gnome is already tracked in #72 |
I use sway, which is a Wayland based successor to i3. I still manage light/dark mode with gsettings, but Auto Dark Mode says it's not supported because it's not one of the selected desktop environments. It should work, because the associated gsettings command does indeed return information about the theme.
auto-dark-mode/base/src/main/java/com/github/weisj/darkmode/platform/LibraryUtil.java
Line 41 in a7dfbeb
It appears that SystemInfo in IntelliJ has similar limitations by design. https://github.com/JetBrains/intellij-community/blob/ceb2e26bfe1707dad40b3de02871b14445d8f766/platform/util/src/com/intellij/openapi/util/SystemInfo.java#L67-L81.
I noticed a recent merged PR #54 which expanded the detection and a discussion at #50 (comment) which I think was discussing adding a
xdg-desktop-portal
component and separate detection.The text was updated successfully, but these errors were encountered: