Skip to content

Commit

Permalink
bug fixed oracle sql parser. fixed issue 1211. alibaba#1211
Browse files Browse the repository at this point in the history
  • Loading branch information
wenshao committed May 6, 2016
1 parent f7105c1 commit d86fb1d
Show file tree
Hide file tree
Showing 3 changed files with 131 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ public SQLExpr primary() {
case REPEAT:
case TABLE:
case TRUNCATE:
case EXCEPTION:
sqlExpr = new SQLIdentifierExpr(lexer.stringVal());
lexer.nextToken();
break;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
* Copyright 1999-2101 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alibaba.druid.bvt.sql.oracle;

import java.util.List;

import org.junit.Assert;

import com.alibaba.druid.sql.OracleTest;
import com.alibaba.druid.sql.SQLUtils;
import com.alibaba.druid.sql.ast.SQLStatement;
import com.alibaba.druid.sql.dialect.oracle.parser.OracleStatementParser;
import com.alibaba.druid.sql.dialect.oracle.visitor.OracleSchemaStatVisitor;
import com.alibaba.druid.stat.TableStat;
import com.alibaba.druid.util.JdbcConstants;

public class OracleInsertTest17 extends OracleTest {

public void test_0() throws Exception {
String sql = "insert into sys_log(ID,EXCEPTION) values(?,?)";

OracleStatementParser parser = new OracleStatementParser(sql);
List<SQLStatement> statementList = parser.parseStatementList();
SQLStatement stmt = statementList.get(0);
print(statementList);

Assert.assertEquals(1, statementList.size());

Assert.assertEquals("INSERT INTO sys_log"
+ "\n\t(ID, EXCEPTION)"
+ "\nVALUES"
+ "\n(?, ?)",//
SQLUtils.toSQLString(stmt, JdbcConstants.ORACLE));

OracleSchemaStatVisitor visitor = new OracleSchemaStatVisitor();
stmt.accept(visitor);

System.out.println("Tables : " + visitor.getTables());
System.out.println("fields : " + visitor.getColumns());
System.out.println("coditions : " + visitor.getConditions());
System.out.println("relationships : " + visitor.getRelationships());

Assert.assertEquals(1, visitor.getTables().size());
Assert.assertEquals(2, visitor.getColumns().size());

Assert.assertTrue(visitor.getTables().containsKey(new TableStat.Name("sys_log")));

Assert.assertTrue(visitor.getColumns().contains(new TableStat.Column("sys_log", "ID")));
Assert.assertTrue(visitor.getColumns().contains(new TableStat.Column("sys_log", "EXCEPTION")));
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
* Copyright 1999-2101 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alibaba.druid.bvt.sql.oracle;

import java.util.List;

import org.junit.Assert;

import com.alibaba.druid.sql.OracleTest;
import com.alibaba.druid.sql.SQLUtils;
import com.alibaba.druid.sql.ast.SQLStatement;
import com.alibaba.druid.sql.dialect.oracle.parser.OracleStatementParser;
import com.alibaba.druid.sql.dialect.oracle.visitor.OracleSchemaStatVisitor;
import com.alibaba.druid.stat.TableStat;
import com.alibaba.druid.util.JdbcConstants;

public class OracleInsertTest18 extends OracleTest {

public void test_0() throws Exception {
String sql = "insert into sys_log(ID,\"EXCEPTION\") values(?,?)";

OracleStatementParser parser = new OracleStatementParser(sql);
List<SQLStatement> statementList = parser.parseStatementList();
SQLStatement stmt = statementList.get(0);
print(statementList);

Assert.assertEquals(1, statementList.size());

Assert.assertEquals("INSERT INTO sys_log"
+ "\n\t(ID, \"EXCEPTION\")"
+ "\nVALUES"
+ "\n(?, ?)",//
SQLUtils.toSQLString(stmt, JdbcConstants.ORACLE));

OracleSchemaStatVisitor visitor = new OracleSchemaStatVisitor();
stmt.accept(visitor);

System.out.println("Tables : " + visitor.getTables());
System.out.println("fields : " + visitor.getColumns());
System.out.println("coditions : " + visitor.getConditions());
System.out.println("relationships : " + visitor.getRelationships());

Assert.assertEquals(1, visitor.getTables().size());
Assert.assertEquals(2, visitor.getColumns().size());

Assert.assertTrue(visitor.getTables().containsKey(new TableStat.Name("sys_log")));

Assert.assertTrue(visitor.getColumns().contains(new TableStat.Column("sys_log", "ID")));
Assert.assertTrue(visitor.getColumns().contains(new TableStat.Column("sys_log", "EXCEPTION")));
}

}

0 comments on commit d86fb1d

Please sign in to comment.