Skip to content

Commit

Permalink
bug fixed for oracle sql parser delete statement alias output. for is…
Browse files Browse the repository at this point in the history
  • Loading branch information
wenshao committed May 10, 2017
1 parent 6c8169b commit f10921e
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -245,13 +245,12 @@ public boolean visit(OracleDeleteStatement x) {
print0(ucase ? "ONLY (" : "only (");
x.getTableName().accept(this);
print(')');

printAlias(x.getAlias());
} else {
x.getTableSource().accept(this);
}

printAlias(x.getAlias());


if (x.getWhere() != null) {
println();
incrementIndent();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/*
* Copyright 1999-2017 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alibaba.druid.bvt.sql.oracle;

import com.alibaba.druid.sql.OracleTest;
import com.alibaba.druid.sql.SQLUtils;
import com.alibaba.druid.sql.ast.SQLStatement;
import com.alibaba.druid.sql.dialect.oracle.parser.OracleStatementParser;
import com.alibaba.druid.sql.dialect.oracle.visitor.OracleSchemaStatVisitor;
import com.alibaba.druid.stat.TableStat;
import org.junit.Assert;

import java.util.List;

public class OracleDeleteTest_3 extends OracleTest {

public void test_0() throws Exception {
String sql = "delete from credit_corp_baseinfo o where o.applyid in(24032,23942,23579,23511,23408,23327,23322,23230,23228,23218);";

OracleStatementParser parser = new OracleStatementParser(sql);
List<SQLStatement> statementList = parser.parseStatementList();
SQLStatement stmt = statementList.get(0);

Assert.assertEquals(1, statementList.size());

OracleSchemaStatVisitor visitor = new OracleSchemaStatVisitor();
stmt.accept(visitor);

Assert.assertEquals(1, visitor.getTables().size());
Assert.assertEquals(1, visitor.getColumns().size());

Assert.assertTrue(visitor.getTables().containsKey(new TableStat.Name("credit_corp_baseinfo")));
//
Assert.assertTrue(visitor.getColumns().contains(new TableStat.Column("credit_corp_baseinfo", "applyid")));
// Assert.assertTrue(visitor.getColumns().contains(new TableStat.Column("employees", "salary")));
// Assert.assertTrue(visitor.getColumns().contains(new TableStat.Column("employees", "commission_pct")));

{
String output = SQLUtils.toOracleString(stmt);
Assert.assertEquals("DELETE FROM credit_corp_baseinfo o\n" +
"WHERE o.applyid IN (24032, 23942, 23579, 23511, 23408, 23327, 23322, 23230, 23228, 23218)", //
output);
}
{
String output = SQLUtils.toOracleString(stmt, SQLUtils.DEFAULT_LCASE_FORMAT_OPTION);
Assert.assertEquals("delete from credit_corp_baseinfo o\n" +
"where o.applyid in (24032, 23942, 23579, 23511, 23408, 23327, 23322, 23230, 23228, 23218)", //
output);
}
}

}

0 comments on commit f10921e

Please sign in to comment.