Resolving fix deleting files #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…By now, only files with exact file name are removed. Copy files (file.log.1, file.log-21-09-2017,...) were not included
# Conflicts: # README.md # index.js
…By now, only files with exact file name are removed. Copy files (file.log.1, file.log-21-09-2017,...) were not included
|
@amcereijo Some long-overdue refactoring of the transport has occurred. A PR is available at #107. Also, a pre-release version has been published to npm. Please npm install [email protected]. This version should address the issue brought forward with this PR. Please set the Closing for now. Please re-open if you continue to see old files remaining. |
|
@mattberther when are you going to publish a final version for 2.0? |
|
@amcereijo I'm just waiting for word from @indexzero that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a log file was versioned the versioned files were not be deleted.
Example:
A log file called
mylog.log.Each time the file reach 50mb it will be versioned.
It will create
mylog.log.1,mylog.log.2, etc... (for example)Until now the process only deleted
mylog.log. From now on, the process also will deletemylog.log1,mylog.log.2, etc...