fix: correctly pass cookies

packages/astro/src/core/app/index.ts

@@ -244,14 +244,15 @@ export class App {
 					onRequest as MiddlewareResponseHandler,
 					apiContext,
 					() => {
-						return renderPage({ mod, renderContext, env: this.#env });
+						return renderPage({ mod, renderContext, env: this.#env, cookies: apiContext.cookies });
 					}
 				);
 			} else {
 				response = await renderPage({
 					mod,
 					renderContext,
 					env: this.#env,
+					cookies: apiContext.cookies,
 				});
 			}
 			Reflect.set(request, responseSentSymbol, true);

packages/astro/src/core/build/generate.ts

@@ -600,6 +600,7 @@ async function generatePath(
 							renderContext,
 							env,
 							isCompressHTML: settings.config.compressHTML,
+							cookies: apiContext.cookies,
 						});
 					}
 				);
@@ -609,6 +610,7 @@ async function generatePath(
 					renderContext,
 					env,
 					isCompressHTML: settings.config.compressHTML,
+					cookies: apiContext.cookies,
 				});
 			}
 		} catch (err) {

packages/astro/src/core/render/core.ts

@@ -1,4 +1,4 @@
-import type { APIContext, ComponentInstance, Params, Props, RouteData } from '../../@types/astro';
+import type { AstroCookies, ComponentInstance, Params, Props, RouteData } from '../../@types/astro';
 import { render, renderPage as runtimeRenderPage } from '../../runtime/server/index.js';
 import { attachToResponse } from '../cookies/index.js';
 import { AstroError, AstroErrorData } from '../errors/index.js';
@@ -109,9 +109,16 @@ export type RenderPage = {
 	renderContext: RenderContext;
 	env: Environment;
 	isCompressHTML?: boolean;
+	cookies: AstroCookies;
 };
 
-export async function renderPage({ mod, renderContext, env, isCompressHTML = false }: RenderPage) {
+export async function renderPage({
+	mod,
+	renderContext,
+	env,
+	cookies,
+	isCompressHTML = false,
+}: RenderPage) {
 	if (routeIsRedirect(renderContext.route)) {
 		return new Response(null, {
 			status: redirectRouteStatus(renderContext.route, renderContext.request.method),
@@ -146,7 +153,7 @@ export async function renderPage({ mod, renderContext, env, isCompressHTML = fal
 		scripts: renderContext.scripts,
 		ssr: env.ssr,
 		status: renderContext.status ?? 200,
-		cookies: renderContext.cookies,
+		cookies,
 		locals: renderContext.locals ?? {},
 	});
 

packages/astro/src/core/render/dev/index.ts

@@ -180,22 +180,31 @@ export async function renderPage(options: SSROptions): Promise<Response> {
 		mod,
 		env,
 	});
+	const apiContext = createAPIContext({
+		request: options.request,
+		params: renderContext.params,
+		props: renderContext.props,
+		adapterName: options.env.adapterName,
+	});
 	if (options.middleware) {
 		if (options.middleware && options.middleware.onRequest) {
-			const apiContext = createAPIContext({
-				request: options.request,
-				params: renderContext.params,
-				props: renderContext.props,
-				adapterName: options.env.adapterName,
-			});
-
 			const onRequest = options.middleware.onRequest as MiddlewareResponseHandler;
 			const response = await callMiddleware<Response>(env.logging, onRequest, apiContext, () => {
-				return coreRenderPage({ mod, renderContext, env: options.env });
+				return coreRenderPage({
+					mod,
+					renderContext,
+					env: options.env,
+					cookies: apiContext.cookies,
+				});
 			});
 
 			return response;
 		}
 	}
-	return await coreRenderPage({ mod, renderContext, env: options.env }); // NOTE: without "await", errors won’t get caught below
+	return await coreRenderPage({
+		mod,
+		renderContext,
+		env: options.env,
+		cookies: apiContext.cookies,
+	}); // NOTE: without "await", errors won’t get caught below
 }