Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node adapter should add mode too #6240

Closed
1 task done
ElianCodes opened this issue Feb 13, 2023 · 2 comments · Fixed by #6333
Closed
1 task done

Node adapter should add mode too #6240

ElianCodes opened this issue Feb 13, 2023 · 2 comments · Fixed by #6333
Assignees
@ematipico
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)

Comments

@ElianCodes
Copy link
Member

What version of astro are you using?

2.0.11

Are you using an SSR adapter? If so, which one?

Node

What package manager are you using?

pnpm

What operating system are you using?

Mac

Describe the Bug

  1. Bootstrapping a new project with pnpm create astro@latest and going with all defaults.
  2. Adding Node adapter through pnpx astro add node
  3. config gets updated, but misses the mode option in the Node adapter (see screenshot linked)

Shouldn't we add the mode: 'standalone' as a default with the config when installing the adapter?

image

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-f7h71h

Participation

  • I am willing to submit a pull request for this issue.
@matthewp
Copy link
Contributor

@ematipico this one comes from src/core/add/. I'm not sure if there's an easy/good solution here, so something to discuss.

@matthewp
Copy link
Contributor

Suggestion:

  1. Figure out if any other integrations take arguments.
  2. If so, do the same thing
  3. Maybe come up with a generic way to pass integration specific config to astro add.

@matthewp matthewp added the - P3: minor bug An edge case that only affects very specific usage (priority) label Feb 22, 2023
@ematipico ematipico mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ematipico ematipico

Labels
- P3: minor bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(astro): correctly change configuration when node adapter is added withastro/astro
3 participants
@matthewp @ematipico @ElianCodes